2022-10-29 15:22:46

by KaiLong Wang

Subject: [PATCH] f2fs: replace ternary operator with max()

Fix the following coccicheck warning:

./fs/f2fs/segment.c:877:24-25: WARNING opportunity for max()

Signed-off-by: KaiLong Wang <[email protected]>
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index ada21e83d279..6da92518328c 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -874,7 +874,7 @@ block_t f2fs_get_unusable_blocks(struct f2fs_sb_info *sbi)
}
mutex_unlock(&dirty_i->seglist_lock);

- unusable = holes[DATA] > holes[NODE] ? holes[DATA] : holes[NODE];
+ unusable = max(holes[DATA], holes[NODE]);
if (unusable > ovp_holes)
return unusable - ovp_holes;
return 0;
--
2.25.1

2022-11-01 16:05:35

by Chao Yu

Subject: Re: [PATCH] f2fs: replace ternary operator with max()

On 2022/10/29 22:49, [email protected] wrote:
> Fix the following coccicheck warning:
>
> ./fs/f2fs/segment.c:877:24-25: WARNING opportunity for max()
>
> Signed-off-by: KaiLong Wang <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,