2023-07-20 08:04:15

by hanyu001

Subject: [PATCH] mm: book3s32: add require space around that '?' and ':'

Fix below checkpatch errors:

./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that
'?' (ctx:VxW)
./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that
':' (ctx:VxW)

Signed-off-by: Yu Han <[email protected]>
---
arch/powerpc/mm/book3s32/tlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/book3s32/tlb.c
b/arch/powerpc/mm/book3s32/tlb.c
index 9ad6b56bfec9..de4abfe3d06b 100644
--- a/arch/powerpc/mm/book3s32/tlb.c
+++ b/arch/powerpc/mm/book3s32/tlb.c
@@ -99,7 +99,7 @@ void hash__flush_tlb_page(struct vm_area_struct *vma,
unsigned long vmaddr)
struct mm_struct *mm;
pmd_t *pmd;

- mm = (vmaddr < TASK_SIZE)? vma->vm_mm: &init_mm;
+ mm = (vmaddr < TASK_SIZE) ? vma->vm_mm : &init_mm;
pmd = pmd_off(mm, vmaddr);
if (!pmd_none(*pmd))
flush_hash_pages(mm->context.id, vmaddr, pmd_val(*pmd), 1);

2023-08-04 16:50:24

by Christophe Leroy

Subject: Re: [PATCH] mm: book3s32: add require space around that '?' and ':'

Hello,


Le 20/07/2023 à 09:34, [email protected] a écrit :
> Fix below checkpatch errors:
>
> ./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that
> '?' (ctx:VxW)
> ./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that
> ':' (ctx:VxW)


Can you please explain the purpose of those changes ? Do you use some
tools that get disturbed by such cosmetic errors ? Otherwise what is
your reason ?

We don't accept such standelone minor cosmetic changes at the first
place because it looks like a waste of time.

If you have major reasons to want those changes, please re-submit with a
details explanation in the commit message.

Thanks
Christophe

>
> Signed-off-by: Yu Han <[email protected]>
> ---
>  arch/powerpc/mm/book3s32/tlb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/book3s32/tlb.c
> b/arch/powerpc/mm/book3s32/tlb.c
> index 9ad6b56bfec9..de4abfe3d06b 100644
> --- a/arch/powerpc/mm/book3s32/tlb.c
> +++ b/arch/powerpc/mm/book3s32/tlb.c
> @@ -99,7 +99,7 @@ void hash__flush_tlb_page(struct vm_area_struct *vma,
> unsigned long vmaddr)
>      struct mm_struct *mm;
>      pmd_t *pmd;
>
> -    mm = (vmaddr < TASK_SIZE)? vma->vm_mm: &init_mm;
> +    mm = (vmaddr < TASK_SIZE) ? vma->vm_mm : &init_mm;
>      pmd = pmd_off(mm, vmaddr);
>      if (!pmd_none(*pmd))
>          flush_hash_pages(mm->context.id, vmaddr, pmd_val(*pmd), 1);