2006-09-16 17:16:45

by Jim Cromie

[permalink] [raw]
Subject: Re: [lm-sensors] [RFC-patch 0/3] SuperIO locks coordinator

David Hubbard wrote:
> Hi Jim,
>
>> BTW, are the idle/activate sequences doc'd in your datasheet ?
>> I ask this cuz pc87360 has a superio-exit defined (and used), but no
>> superio-enter(),
>> and I couldnt find the idle/activate sequences docd in my datasheet.
>> With the long history of copy & modify in these drivers, its possible
>> that some cargo-cult features were inadvertently carried forward,
>> esp when drivers are written w/o actually having the hardare.
>>
>> Could you disable your superio-enter(), and see if that breaks the
>> functionality ?
>
> I'll do that and let you know how it goes. I suspect that the BIOS
> initializes the w83627ehf correctly,
yes. very likely
> and so the superio-enter and
> -exit that are used may not be required...except during detection.

Also likely/possible. Some chips can be told to map their logical
devices (LDs)
to specific ISA address ranges, then those devices can be largely or
completely
operated using vanilla IO operations, w/o the superio-port overheads,
and the BIOS often takes care of this, and enables devices that the mobo
is designed to use.

Forex:
6600-660f : pc8736x_gpio
6620-662f : pc87360
6640-664f : pc87360

To complicate things, some LDs have features that are only controllable
via superio, pc8736x GPIO has runtime regs and configuration regs, the
latter
are only available via superio. These LDs are much more dependent upon
proper superio locking, vs hwmon/pc87360, which uses vanilla IO after
detection,
and thus releases the superio-reservation once detection/initialization
is complete.

FYI - GregKH said this on LKML, re 2.6.19
http://marc.theaimsgroup.com/?l=linux-kernel&m=115778993800623&w=2

- The driver core was changed to allow multi-threaded device
probing. This means that every device added to the system
gets a new kernel thread in which to do the probe sequence.
The PCI subsystem was modified to allow PCI drivers to do this
(this is made a configuration option, as it breaks numerous
boxes if enabled). It does have the potential to speed up the
boot sequence a lot for some machines, and is even measurable
on single processor laptops.


This appears to increase the potential of problems related to current
lack of superio locking,


> The
> w83627ehf is mapped into ISA I/O space (probably by the BIOS). So I'll
> test my theory and get back to you soon.
>
thanks.

> David
>
jimc