2006-09-23 00:32:42

by Al Viro

Subject: [PATCH] restore __iomem annotations in e1000

Signed-off-by: Al Viro <[email protected]>
---
drivers/net/e1000/e1000_hw.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/e1000/e1000_hw.h b/drivers/net/e1000/e1000_hw.h
index 375b955..a7e3a82 100644
--- a/drivers/net/e1000/e1000_hw.h
+++ b/drivers/net/e1000/e1000_hw.h
@@ -1365,8 +1365,8 @@ struct e1000_hw_stats {

/* Structure containing variables used by the shared code (e1000_hw.c) */
struct e1000_hw {
- uint8_t *hw_addr;
- uint8_t *flash_address;
+ uint8_t __iomem *hw_addr;
+ uint8_t __iomem *flash_address;
e1000_mac_type mac_type;
e1000_phy_type phy_type;
uint32_t phy_init_script;
--
1.4.2.GIT

2006-09-26 00:08:44

by Jeff Garzik

Subject: Re: [PATCH] restore __iomem annotations in e1000

applied

2006-09-26 05:05:00

by Kok, Auke

Subject: Re: [PATCH] restore __iomem annotations in e1000

Jeff Garzik wrote:
> applied
>

Thanks,

I have no idea why and when these annotations were lost, but we have them in
much older versions of the code. I'll try to track it down and make sure that
it doesn't disappear again.

Cheers,

Auke

2006-09-26 05:32:38

by Jeff Garzik

Subject: Re: [PATCH] restore __iomem annotations in e1000

Auke Kok wrote:
> Jeff Garzik wrote:
>> applied
>>
>
> Thanks,
>
> I have no idea why and when these annotations were lost, but we have
> them in much older versions of the code. I'll try to track it down and
> make sure that it doesn't disappear again.

Just run an sparse check as described in
Documentation/sparse.txt...

Jeff

2006-09-26 17:40:14

by Kok, Auke

Subject: Re: [PATCH] restore __iomem annotations in e1000

Jeff Garzik wrote:
> Auke Kok wrote:
>> Jeff Garzik wrote:
>>> applied
>>>
>>
>> Thanks,
>>
>> I have no idea why and when these annotations were lost, but we have
>> them in much older versions of the code. I'll try to track it down and
>> make sure that it doesn't disappear again.
>
> Just run an sparse check as described in
> Documentation/sparse.txt...

gotcha, I'll try to do this on a regular basis.

Thanks,

Auke