2024-05-21 18:41:07

by Elliot Berman

Subject: [PATCH RFC v3 6/9] arm64: boot: dts: sm8650: Add board-id

Add board-id to match sm8650 MTPs and QRDs.

Signed-off-by: Elliot Berman <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 6 ++++++
arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 6 ++++++
2 files changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
index be133a3d5cbe..ceaf7cc270af 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
@@ -5,6 +5,7 @@

/dts-v1/;

+#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "sm8650.dtsi"
#include "pm8010.dtsi"
@@ -28,6 +29,11 @@ chosen {
stdout-path = "serial0:115200n8";
};

+ board-id {
+ qcom,soc = <QCOM_ID_SM8650>;
+ qcom,platform = <QCOM_BOARD_ID_MTP>;
+ };
+
pmic-glink {
compatible = "qcom,sm8650-pmic-glink",
"qcom,sm8550-pmic-glink",
diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
index b9151c2ddf2e..672ffcd0eaf0 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
@@ -5,6 +5,7 @@

/dts-v1/;

+#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "sm8650.dtsi"
@@ -26,6 +27,11 @@ aliases {
serial1 = &uart14;
};

+ board-id {
+ qcom,soc = <QCOM_ID_SM8650>;
+ qcom,platform = <QCOM_BOARD_ID_QRD>;
+ };
+
chosen {
stdout-path = "serial0:115200n8";
};

--
2.34.1

2024-06-05 08:24:49

by Krzysztof Kozlowski

Subject: Re: [PATCH RFC v3 6/9] arm64: boot: dts: sm8650: Add board-id

On 21/05/2024 20:38, Elliot Berman wrote:
> Add board-id to match sm8650 MTPs and QRDs.
>
> Signed-off-by: Elliot Berman <[email protected]>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> ---
> arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 6 ++++++
> arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 6 ++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> index be133a3d5cbe..ceaf7cc270af 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> @@ -5,6 +5,7 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/arm/qcom,ids.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "sm8650.dtsi"
> #include "pm8010.dtsi"
> @@ -28,6 +29,11 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + board-id {
> + qcom,soc = <QCOM_ID_SM8650>;
> + qcom,platform = <QCOM_BOARD_ID_MTP>;

I don't see a single benefit of this. This duplicates compatible and
brings absolutely no new information for the bootloaders.


Best regards,
Krzysztof