2006-10-12 05:55:07

by Pierre Ossman

[permalink] [raw]
Subject: Re: Fwd: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume

Doesn't Jeff love me anymore? :(

Alex Dubov wrote:
> --- Jeff Garzik <[email protected]> wrote:
>
>
>> Date: Wed, 11 Oct 2006 17:48:09 -0400
>> From: Jeff Garzik <[email protected]>
>> To: [email protected], Andrew Morton <[email protected]>,
>> LKML <[email protected]>
>> Subject: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume
>>
>>
>> Since pci_enable_device() is one of the first things called in the
>> resume step, take the minimalist approach and return immediately, if
>> pci_enable_device() fails during resume.
>>
>> Also, in sdhci: don't check for impossible condition (chip==NULL)
>>
>> Signed-off-by: Jeff Garzik <[email protected]>
>>
>>

I'm just being cautious. "This can't happen" is usually the last thing
you here before the end. ;)

Signed-off-by: Pierre Ossman <[email protected]>

Rgds

--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
OLPC, developer http://www.laptop.org