2006-10-16 08:08:57

by Vasily Averin

[permalink] [raw]

Subject: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix

---

--- linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c.mgst6 2006-10-16 10:26:50.000000000 +0400
+++ linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c 2006-10-16 11:30:55.000000000 +0400
@@ -884,7 +884,7 @@ megaraid_init_mbox(adapter_t *adapter)

if (((magic64 == HBA_SIGNATURE_64_BIT) &&
((adapter->pdev->subsystem_device !=
- PCI_SUBSYS_ID_MEGARAID_SATA_150_6) ||
+ PCI_SUBSYS_ID_MEGARAID_SATA_150_6) &&
(adapter->pdev->subsystem_device !=
PCI_SUBSYS_ID_MEGARAID_SATA_150_4))) ||
(adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&

---

Attachments:

diff-megaraid-sata1506-20061016 (562.00 B)

2006-10-16 12:32:30

by Ju, Seokmann

[permalink] [raw]

Subject: RE: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix

---

Hi,
Monday, October 16, 2006 4:09 AM, Vasily Averin wrote:
> It is known that 2 LSI Logic MegaRAID SATA RAID Controllers
> (150-4 and 150-6)
> don't support 64-bit DMA. Unfortunately currently this check
> is wrong and driver
> sets 64-bit DMA mode for these devices.
ACK - this patch will fix the problem.
Thank you for the finding, Vasily.

Seokmann

> -----Original Message-----
> From: Vasily Averin [mailto:[email protected]]
> Sent: Monday, October 16, 2006 4:09 AM
> To: Linux Kernel Mailing List; [email protected];
> Ju, Seokmann; James Bottomley; Andrew Morton; Linus Torvalds;
> [email protected]
> Cc: Andrey Mirkin
> Subject: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit
> DMA capability fix
>
> From: Andrey Mirkin ([email protected])
>
> It is known that 2 LSI Logic MegaRAID SATA RAID Controllers
> (150-4 and 150-6)
> don't support 64-bit DMA. Unfortunately currently this check
> is wrong and driver
> sets 64-bit DMA mode for these devices.
>
> Signed-off-by: Andrey Mirkin <[email protected]>
> Ack-by: Vasily Averin <[email protected]>
>
> ---
> linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c.mgst6
> 2006-10-16
> 10:26:50.000000000 +0400
> +++ linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c
> 2006-10-16
> 11:30:55.000000000 +0400
> @@ -884,7 +884,7 @@ megaraid_init_mbox(adapter_t *adapter)
>
> if (((magic64 == HBA_SIGNATURE_64_BIT) &&
> ((adapter->pdev->subsystem_device !=
> - PCI_SUBSYS_ID_MEGARAID_SATA_150_6) ||
> + PCI_SUBSYS_ID_MEGARAID_SATA_150_6) &&
> (adapter->pdev->subsystem_device !=
> PCI_SUBSYS_ID_MEGARAID_SATA_150_4))) ||
> (adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&
>
>

2006-10-16 19:34:56

by James Bottomley

[permalink] [raw]

Subject: Re: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix

---

On Mon, 2006-10-16 at 12:08 +0400, Vasily Averin wrote:
> It is known that 2 LSI Logic MegaRAID SATA RAID Controllers (150-4 and 150-6)
> don't support 64-bit DMA. Unfortunately currently this check is wrong and driver
> sets 64-bit DMA mode for these devices.
>
> Signed-off-by: Andrey Mirkin <[email protected]>
> Ack-by: Vasily Averin <[email protected]>
>
> --- linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c.mgst6 2006-10-16
> 10:26:50.000000000 +0400
> +++ linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c 2006-10-16
> 11:30:55.000000000 +0400
> @@ -884,7 +884,7 @@ megaraid_init_mbox(adapter_t *adapter)
>
> if (((magic64 == HBA_SIGNATURE_64_BIT) &&
> ((adapter->pdev->subsystem_device !=
> - PCI_SUBSYS_ID_MEGARAID_SATA_150_6) ||
> + PCI_SUBSYS_ID_MEGARAID_SATA_150_6) &&
> (adapter->pdev->subsystem_device !=
> PCI_SUBSYS_ID_MEGARAID_SATA_150_4))) ||
> (adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&

Er ... this patch would apply in reverse, but what's in the tree
currently looks to be correct.

James