2020-07-12 10:02:12

by kernel test robot

[permalink] [raw]
Subject: arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x2c): undefined reference to `wm97xx_config_gpio'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0aea6d5c5be33ce94c16f9ab2f64de1f481f424b
commit: ff487d41036035376e47972c7c522490b839ab37 MIPS: Truncate link address into 32bit for 32bit kernel
date: 9 weeks ago
config: mips-randconfig-c023-20200712 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

mipsel-linux-ld: arch/mips/alchemy/devboards/db1300.o: in function `db1300_wm97xx_probe':
>> arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x2c): undefined reference to `wm97xx_config_gpio'
>> mipsel-linux-ld: arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x4c): undefined reference to `wm97xx_config_gpio'
>> mipsel-linux-ld: arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x74): undefined reference to `wm97xx_register_mach_ops'

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (1.10 kB)
.config.gz (31.80 kB)
Download all attachments

2020-07-13 01:32:18

by Jiaxun Yang

[permalink] [raw]
Subject: Re: arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x2c): undefined reference to `wm97xx_config_gpio'

在 2020/7/12 18:01, kernel test robot 写道:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 0aea6d5c5be33ce94c16f9ab2f64de1f481f424b
> commit: ff487d41036035376e47972c7c522490b839ab37 MIPS: Truncate link address into 32bit for 32bit kernel
> date: 9 weeks ago
> config: mips-randconfig-c023-20200712 (attached as .config)
> compiler: mipsel-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> mipsel-linux-ld: arch/mips/alchemy/devboards/db1300.o: in function `db1300_wm97xx_probe':

Well this seems unrelated with my changes.

Just wonder if alchemy still alive?
Should I fix it or just drop alchemy support?

- Jiaxun

>>> arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x2c): undefined reference to `wm97xx_config_gpio'
>>> mipsel-linux-ld: arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x4c): undefined reference to `wm97xx_config_gpio'
>>> mipsel-linux-ld: arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x74): undefined reference to `wm97xx_register_mach_ops'
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/[email protected]

2020-07-13 11:10:42

by Manuel Lauss

[permalink] [raw]
Subject: Re: arch/mips/alchemy/devboards/db1300.c:(.text.db1300_wm97xx_probe+0x2c): undefined reference to `wm97xx_config_gpio'

Hello all,

On Mon, Jul 13, 2020 at 3:29 AM Jiaxun Yang <[email protected]> wrote:
>
> 在 2020/7/12 18:01, kernel test robot 写道:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 0aea6d5c5be33ce94c16f9ab2f64de1f481f424b
> > commit: ff487d41036035376e47972c7c522490b839ab37 MIPS: Truncate link address into 32bit for 32bit kernel
> > date: 9 weeks ago
> > config: mips-randconfig-c023-20200712 (attached as .config)
> > compiler: mipsel-linux-gcc (GCC) 9.3.0
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>):
> >
> > mipsel-linux-ld: arch/mips/alchemy/devboards/db1300.o: in function `db1300_wm97xx_probe':
>
> Well this seems unrelated with my changes.

Yes,

> Just wonder if alchemy still alive?

My test hardware still works

> Should I fix it or just drop alchemy support?

Something like this should fix it. I never tested randconfig because I find
it kind of pointless for these kinds of specialized boards/systems.

diff --git a/arch/mips/alchemy/devboards/db1300.c
b/arch/mips/alchemy/devboards/db1300.c
index 8ac1f56ee57d..9c7736d88bce 100644
--- a/arch/mips/alchemy/devboards/db1300.c
+++ b/arch/mips/alchemy/devboards/db1300.c
@@ -746,6 +746,7 @@ static struct wm97xx_mach_ops db1300_wm97xx_ops = {

static int db1300_wm97xx_probe(struct platform_device *pdev)
{
+#if IS_ENABLED(CONFIG_TOUCHSCREEN_WM97XX)
struct wm97xx *wm = platform_get_drvdata(pdev);

/* external pendown indicator */
@@ -761,6 +762,9 @@ static int db1300_wm97xx_probe(struct platform_device *pdev)
wm->pen_irq = DB1300_AC97_PEN_INT;

return wm97xx_register_mach_ops(wm, &db1300_wm97xx_ops);
+#else
+ return -ENODEV;
+#endif
}


Manuel