2006-10-18 04:28:21

by Dave Jones

Subject: [IPMI] Fix return codes in failure case.

These returns should be negative, like the others in this function.

Signed-off-by: Dave Jones <[email protected]>

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 24825bd..e5cfb1f 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1789,7 +1789,7 @@ static int __devinit ipmi_pci_probe(stru

info = kzalloc(sizeof(*info), GFP_KERNEL);
if (!info)
- return ENOMEM;
+ return -ENOMEM;

info->addr_source = "PCI";

@@ -1810,7 +1810,7 @@ static int __devinit ipmi_pci_probe(stru
kfree(info);
printk(KERN_INFO "ipmi_si: %s: Unknown IPMI type: %d\n",
pci_name(pdev), class_type);
- return ENOMEM;
+ return -ENOMEM;
}

rv = pci_enable_device(pdev);

--
http://www.codemonkey.org.uk

2006-10-18 15:05:55

by Corey Minyard

Subject: Re: [IPMI] Fix return codes in failure case.

Thanks, looks good.

-Corey

Dave Jones wrote:
> These returns should be negative, like the others in this function.
>
> Signed-off-by: Dave Jones <[email protected]>
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 24825bd..e5cfb1f 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1789,7 +1789,7 @@ static int __devinit ipmi_pci_probe(stru
>
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> if (!info)
> - return ENOMEM;
> + return -ENOMEM;
>
> info->addr_source = "PCI";
>
> @@ -1810,7 +1810,7 @@ static int __devinit ipmi_pci_probe(stru
> kfree(info);
> printk(KERN_INFO "ipmi_si: %s: Unknown IPMI type: %d\n",
> pci_name(pdev), class_type);
> - return ENOMEM;
> + return -ENOMEM;
> }
>
> rv = pci_enable_device(pdev);
>
>