2024-05-03 02:22:52

by Ashok Kumar

Subject: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

Corrected coding style CHECK: Alignment should match open parenthesis

Signed-off-by: Ashok Kumar <[email protected]>
---
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
index 9469248f2c50..60cda57bcb33 100644
--- a/drivers/staging/fbtft/fb_tinylcd.c
+++ b/drivers/staging/fbtft/fb_tinylcd.c
@@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xE5, 0x00);
write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
- 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+ 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
udelay(250);
--
2.34.1

2024-05-03 05:12:06

by Dan Carpenter

Subject: Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

On Thu, May 02, 2024 at 06:52:16PM -0700, Ashok Kumar wrote:
> Corrected coding style CHECK: Alignment should match open parenthesis
>

The original author was aligned it deliberately to improve readability.

Just ignore checkpatch on this.

regards,
dan carpenter

2024-05-03 06:55:13

by Julia Lawall

Subject: Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

On Thu, 2 May 2024, Ashok Kumar wrote:

> Corrected coding style CHECK: Alignment should match open parenthesis

Ashok, I think the code is nicer as is, because it has all the constant
numbers lined up.

julia

>
> Signed-off-by: Ashok Kumar <[email protected]>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index 9469248f2c50..60cda57bcb33 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0xE5, 0x00);
> write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
> write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
> write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
> udelay(250);
> --
> 2.34.1
>
>
>

2024-05-03 17:02:06

by Ashok Kumar

Subject: Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

On Thursday, May 2, 2024 at 11:54:58 PM PDT, Julia Lawall <[email protected]> wrote:







On Thu, 2 May 2024, Ashok Kumar wrote:

> Corrected coding style CHECK: Alignment should match open parenthesis

Ashok, I think the code is nicer as is, because it has all the constant
numbers lined up.

julia

Thanks for the update I will ignore this change. 

Is there a list of exceptions to the checkpatch information that we can ignore in general.


>
> Signed-off-by: Ashok Kumar <[email protected]>
> ---
>  drivers/staging/fbtft/fb_tinylcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index 9469248f2c50..60cda57bcb33 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
>      write_reg(par, 0xE5, 0x00);
>      write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
>      write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> -              0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> +          0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
>      write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
>      write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
>      udelay(250);
> --
> 2.34.1
>
>
>

2024-05-04 11:18:22

by Dan Carpenter

Subject: Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

On Fri, May 03, 2024 at 04:20:24PM +0000, Ashok Kumar wrote:
>
> Is there a list of exceptions to the checkpatch information that we can ignore in general.
>

For Greg's subsystems ignore the warning about extra parentheses.
You can search on lore for if a patch has been patch has been sent
before. Otherwise ignore checkpatch if it tells you to do something
that makes the code less readable.

regards,
dan carpenter