2022-11-25 08:20:38

by ye.xingchen

Subject: [PATCH] hwspinlock: Use device_match_of_node()

From: ye xingchen <[email protected]>

Replace the open-code with device_match_of_node().

Signed-off-by: ye xingchen <[email protected]>
---
drivers/hwspinlock/hwspinlock_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers/hwspinlock/hwspinlock_core.c
index fd5f5c5a5244..22b8f2a70b3b 100644
--- a/drivers/hwspinlock/hwspinlock_core.c
+++ b/drivers/hwspinlock/hwspinlock_core.c
@@ -367,7 +367,7 @@ int of_hwspin_lock_get_id(struct device_node *np, int index)
continue;
}

- if (hwlock->bank->dev->of_node == args.np) {
+ if (device_match_of_node(hwlock->bank->dev, args.np)) {
ret = 0;
break;
}
--
2.25.1

2022-11-25 08:36:39

by Baolin Wang

Subject: Re: [PATCH] hwspinlock: Use device_match_of_node()

On 11/25/2022 3:44 PM, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Replace the open-code with device_match_of_node().
>
> Signed-off-by: ye xingchen <[email protected]>

LGTM.
Reviewed-by: Baolin Wang <[email protected]>

> ---
> drivers/hwspinlock/hwspinlock_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers/hwspinlock/hwspinlock_core.c
> index fd5f5c5a5244..22b8f2a70b3b 100644
> --- a/drivers/hwspinlock/hwspinlock_core.c
> +++ b/drivers/hwspinlock/hwspinlock_core.c
> @@ -367,7 +367,7 @@ int of_hwspin_lock_get_id(struct device_node *np, int index)
> continue;
> }
>
> - if (hwlock->bank->dev->of_node == args.np) {
> + if (device_match_of_node(hwlock->bank->dev, args.np)) {
> ret = 0;
> break;
> }

2022-12-14 14:38:55

by Philippe Mathieu-Daudé

Subject: Re: [PATCH] hwspinlock: Use device_match_of_node()

On 25/11/22 08:44, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Replace the open-code with device_match_of_node().
>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/hwspinlock/hwspinlock_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

2022-12-28 18:43:17

by Bjorn Andersson

Subject: Re: [PATCH] hwspinlock: Use device_match_of_node()

On Fri, 25 Nov 2022 15:44:36 +0800 (CST), [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Replace the open-code with device_match_of_node().
>
>

Applied, thanks!

[1/1] hwspinlock: Use device_match_of_node()
commit: ec5c05e5ac8bcb4a6bcd92970e15494a85400d34

Best regards,
--
Bjorn Andersson <[email protected]>