2006-10-29 09:26:12

by Pierre Ossman

[permalink] [raw]
Subject: Re: [patch 1/6] [RFC] Add MMC Password Protection (lock/unlock) support V5

Carlos Aguiar wrote:
> When a card is locked, only commands from the "basic" and "lock card" classes
> are accepted. To be able to use the other commands, the card must be unlocked
> first.
>
> This patch prevents the block driver from trying to run privileged class
> commands on locked MMC cards, which will fail anyway.
>

Incorrect commit message. It stops driver probes (all of them).

> 20 11:41:54.000000000 -0400
> @@ -85,6 +85,7 @@ struct mmc_host {
> unsigned long caps; /* Host capabilities */
>
> #define MMC_CAP_4_BIT_DATA (1 << 0) /* Can the host do 4 bit transfers */
> +#define MMC_CAP_LOCK_UNLOCK (1 << 1) /* Host password support capability */
>
> /* host specific block data */
> unsigned int max_seg_size; /* see blk_queue_max_segment_size */
>
>

You need to rebase your patch set on a more recent kernel. This won't
apply cleanly.

Rgds

--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org