2006-11-14 10:57:18

by Emmanuel Fleury

Subject: [UML] arch/um/os-Linux/skas/process.c:328: error: 'PAGE_SHIFT' undeclared

Hi,

Some problems in 2.6.18.2 with UML:

arch/um/os-Linux/skas/process.c: In function 'copy_context_skas0':
arch/um/os-Linux/skas/process.c:328: error: 'PAGE_SHIFT' undeclared
(first use in this function)
arch/um/os-Linux/skas/process.c:328: error: (Each undeclared identifier
is reported only once
arch/um/os-Linux/skas/process.c:328: error: for each function it appears
in.)
arch/um/os-Linux/skas/process.c:560:2: warning: #warning need cpu pid in
switch_mm_skas
make[2]: *** [arch/um/os-Linux/skas/process.o] Error 1
make[1]: *** [arch/um/os-Linux/skas] Error 2
make[1]: *** Waiting for unfinished jobs....

Solved with the following patch (probably already solved but just in
case you didn't...):

--- arch/um/include/sysdep-i386/stub.h.orig 2006-11-04
02:33:58.000000000 +0100
+++ arch/um/include/sysdep-i386/stub.h 2006-11-14
11:23:20.000000000 +0100
@@ -12,6 +12,7 @@
#include "stub-data.h"
#include "kern_constants.h"
#include "uml-config.h"
+#include "asm/page.h"

extern void stub_segv_handler(int sig);
extern void stub_clone_handler(void);

Regards
--
Emmanuel Fleury | Office: 261
Associate Professor, | Phone: +33 (0)5 40 00 69 34
LaBRI, Domaine Universitaire | Fax: +33 (0)5 40 00 66 69
351, Cours de la Lib?ration | email: [email protected]
33405 Talence Cedex, France | URL: http://www.labri.fr/~fleury

2006-11-14 14:34:53

by Jeff Dike

Subject: Re: [UML] arch/um/os-Linux/skas/process.c:328: error: 'PAGE_SHIFT' undeclared

On Tue, Nov 14, 2006 at 11:56:23AM +0100, Emmanuel Fleury wrote:
> arch/um/os-Linux/skas/process.c: In function 'copy_context_skas0':
> arch/um/os-Linux/skas/process.c:328: error: 'PAGE_SHIFT' undeclared
> (first use in this function)

> Solved with the following patch (probably already solved but just in
> case you didn't...):

Yup, I added that to my tree last night.

Jeff

--
Work email - jdike at linux dot intel dot com