2006-11-19 20:51:08

by Randy Dunlap

[permalink] [raw]
Subject: ipath uses skb functions

but doesn't depends on NET (Networking).

drivers/built-in.o: In function `ipath_free_pddata':
(.text.ipath_free_pddata+0x155): undefined reference to `kfree_skb'
drivers/built-in.o: In function `ipath_alloc_skb':
(.text.ipath_alloc_skb+0x28): undefined reference to `__alloc_skb'
drivers/built-in.o: In function `ipath_init_chip':
(.text.ipath_init_chip+0xe61): undefined reference to `kfree_skb'
make: *** [vmlinux] Error 1

2.6.19-rc6-git2

---
~Randy


2006-11-20 18:54:35

by Bryan O'Sullivan

[permalink] [raw]
Subject: Re: ipath uses skb functions

Randy Dunlap wrote:
> but doesn't depends on NET (Networking).

Thanks. One-liner patch attached. Roland, please add this to your
for-2.6.19 or for-2.6.20 queue, as you see fit.

<b


Attachments:
ipath-config-net.patch (700.00 B)

2006-11-20 19:07:09

by Randy Dunlap

[permalink] [raw]
Subject: Re: ipath uses skb functions

Bryan O'Sullivan wrote:
> Randy Dunlap wrote:
>> but doesn't depends on NET (Networking).
>
> Thanks. One-liner patch attached. Roland, please add this to your
> for-2.6.19 or for-2.6.20 queue, as you see fit.
>
> <b

Acked-by: Randy Dunlap <[email protected]>

> ------------------------------------------------------------------------
>
> IB/ipath - make Kconfig depend on CONFIG_NET
>
> Spotted by Randy Dunlap.
>
> Signed-off-by: Bryan O'Sullivan <[email protected]>
>
> diff -r 9769053d8f77 drivers/infiniband/hw/ipath/Kconfig
> --- a/drivers/infiniband/hw/ipath/Kconfig Tue Nov 14 10:07:29 2006 -0800
> +++ b/drivers/infiniband/hw/ipath/Kconfig Mon Nov 20 10:51:25 2006 -0800
> @@ -1,6 +1,6 @@ config INFINIBAND_IPATH
> config INFINIBAND_IPATH
> tristate "QLogic InfiniPath Driver"
> - depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND
> + depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND && NET
> ---help---
> This is a driver for QLogic InfiniPath host channel adapters,
> including InfiniBand verbs support. This driver allows these


--
~Randy

2006-11-20 21:05:27

by Roland Dreier

[permalink] [raw]
Subject: Re: ipath uses skb functions

Thanks, applied.