2006-11-30 09:38:33

by Mariusz Kozlowski

Subject: [PATCH] fs: reiserfs add missing brackets

Hello,

This patch adds missing brackets.

include/linux/reiserfs_fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.19-rc6-mm2-a/include/linux/reiserfs_fs.h 2006-11-28 12:17:06.000000000 +0100
+++ linux-2.6.19-rc6-mm2-b/include/linux/reiserfs_fs.h 2006-11-30 01:05:38.000000000 +0100
@@ -739,7 +739,7 @@ struct block_head {
#define PUT_B_FREE_SPACE(p_s_bh,val) do { set_blkh_free_space(B_BLK_HEAD(p_s_bh),val); } while (0)

/* Get right delimiting key. -- little endian */
-#define B_PRIGHT_DELIM_KEY(p_s_bh) (&(blk_right_delim_key(B_BLK_HEAD(p_s_bh))
+#define B_PRIGHT_DELIM_KEY(p_s_bh) (&(blk_right_delim_key(B_BLK_HEAD(p_s_bh))))

/* Does the buffer contain a disk leaf. */
#define B_IS_ITEMS_LEVEL(p_s_bh) (B_LEVEL(p_s_bh) == DISK_LEAF_NODE_LEVEL)


--
Regards,

Mariusz Kozlowski

2006-11-30 16:22:01

by Phillip Susi

Subject: Re: [PATCH] fs: reiserfs add missing brackets

I know it is just nit-picking, but those are parenthesis, not brackets.

() vs. []

Mariusz Kozlowski wrote:
> Hello,
>
> This patch adds missing brackets.
>
> include/linux/reiserfs_fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.19-rc6-mm2-a/include/linux/reiserfs_fs.h 2006-11-28 12:17:06.000000000 +0100
> +++ linux-2.6.19-rc6-mm2-b/include/linux/reiserfs_fs.h 2006-11-30 01:05:38.000000000 +0100
> @@ -739,7 +739,7 @@ struct block_head {
> #define PUT_B_FREE_SPACE(p_s_bh,val) do { set_blkh_free_space(B_BLK_HEAD(p_s_bh),val); } while (0)
>
> /* Get right delimiting key. -- little endian */
> -#define B_PRIGHT_DELIM_KEY(p_s_bh) (&(blk_right_delim_key(B_BLK_HEAD(p_s_bh))
> +#define B_PRIGHT_DELIM_KEY(p_s_bh) (&(blk_right_delim_key(B_BLK_HEAD(p_s_bh))))
>
> /* Does the buffer contain a disk leaf. */
> #define B_IS_ITEMS_LEVEL(p_s_bh) (B_LEVEL(p_s_bh) == DISK_LEAF_NODE_LEVEL)
>
>