2006-12-10 17:04:29

by Aneesh Kumar K.V

[permalink] [raw]
Subject: Re: kobject_uevent() question

Greg KH wrote:
> On Tue, Nov 28, 2006 at 07:38:01PM +0000, Mauricio Lin wrote:
>> Hi Greg,
>>
>> It is working now. The failure was in the kobject_uevent() function. As
>> the kset of my kobject was not set properly, the kobject_uevent()
>> function just returned void.
>>
>> I wonder why the kobjec_uevent() does not return an integer to indicate
>> if the operation was completed with success or not.
>
> Feel free to send patches fixing this issue :)
>
> thanks,
>
>

Something like this ?

-aneesh


Attachments:
kobject_uevent.diff (3.88 kB)

2006-12-11 14:53:59

by Mauricio Lin

[permalink] [raw]
Subject: Re: kobject_uevent() question

Hi Aneesh,

I have posted a patch for that as well. You can check it at
http://lkml.org/lkml/2006/11/30/315.

BR,

Mauricio Lin.

On 12/10/06, Aneesh Kumar K.V <[email protected]> wrote:
> Greg KH wrote:
> > On Tue, Nov 28, 2006 at 07:38:01PM +0000, Mauricio Lin wrote:
> >> Hi Greg,
> >>
> >> It is working now. The failure was in the kobject_uevent() function. As
> >> the kset of my kobject was not set properly, the kobject_uevent()
> >> function just returned void.
> >>
> >> I wonder why the kobjec_uevent() does not return an integer to indicate
> >> if the operation was completed with success or not.
> >
> > Feel free to send patches fixing this issue :)
> >
> > thanks,
> >
> >
>
> Something like this ?
>
> -aneesh
>
>
>

2006-12-11 16:31:51

by Aneesh Kumar K.V

[permalink] [raw]
Subject: Re: kobject_uevent() question

On 12/11/06, Mauricio Lin <[email protected]> wrote:
> Hi Aneesh,
>
> I have posted a patch for that as well. You can check it at
> http://lkml.org/lkml/2006/11/30/315.
>


Changes i posted was with respect to a latest kernel and also had some
more failure case properly returning error. So i picked my diff added
the commit message and function documentation from your diff. I have
posted a new diff with sign-off. Let me know what you think.

-aneesh