On Wed, May 4, 2022 at 11:14 AM kernel test robot <[email protected]> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 107c948d1d3e61d10aee9d0f7c3d81bbee9842af
> commit: 8b22820efb35f93d98638563b0a8f4094e8ee399 m68k: m68328: remove duplicate code
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl':
> >> time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll'
> m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll'
> m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll'
>
I think this is just another build failure that was hidden before my patch,
not caused by my patch.
Arnd
Hi Arnd,
On Wed, May 4, 2022 at 2:25 PM Arnd Bergmann <[email protected]> wrote:
> On Wed, May 4, 2022 at 11:14 AM kernel test robot <[email protected]> wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 107c948d1d3e61d10aee9d0f7c3d81bbee9842af
> > commit: 8b22820efb35f93d98638563b0a8f4094e8ee399 m68k: m68328: remove duplicate code
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>):
> >
> > m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl':
> > >> time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll'
> > m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll'
> > m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll'
> >
>
> I think this is just another build failure that was hidden before my patch,
> not caused by my patch.
That's an m68knommu kernel build with CONFIG_RTC_DRV_GENERIC=y,
I guess?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On 5/4/2022 5:25 PM, Arnd Bergmann wrote:
> On Wed, May 4, 2022 at 11:14 AM kernel test robot <[email protected]> wrote:
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 107c948d1d3e61d10aee9d0f7c3d81bbee9842af
>> commit: 8b22820efb35f93d98638563b0a8f4094e8ee399 m68k: m68328: remove duplicate code
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <[email protected]>
>>
>> All errors (new ones prefixed by >>):
>>
>> m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl':
>>>> time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll'
>> m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll'
>> m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll'
>>
>
> I think this is just another build failure that was hidden before my patch,
> not caused by my patch.
>
> Arnd
Hi Arnd,
Sorry for the inconvenience, we have added it to the ignore list.
Best Regards,
Rong Chen
On Wed, May 4, 2022 at 3:33 PM Geert Uytterhoeven <[email protected]> wrote:
> On Wed, May 4, 2022 at 2:25 PM Arnd Bergmann <[email protected]> wrote:
> > On Wed, May 4, 2022 at 11:14 AM kernel test robot <[email protected]> wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head: 107c948d1d3e61d10aee9d0f7c3d81bbee9842af
> > > commit: 8b22820efb35f93d98638563b0a8f4094e8ee399 m68k: m68328: remove duplicate code
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <[email protected]>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl':
> > > >> time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll'
> > > m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll'
> > > m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll'
> > >
> >
> > I think this is just another build failure that was hidden before my patch,
> > not caused by my patch.
>
> That's an m68knommu kernel build with CONFIG_RTC_DRV_GENERIC=y,
> I guess?
Correct, the .config file is linked in the original report, just double-checked
that. More importantly, it's a nommu M68KCLASSIC (dragonball) config,
so the existing #ifdef CONFIG_M68KCLASSIC check in
arch/m68k/kernel/time.c is insufficient.
Arnd
On 5/4/22 06:33, Geert Uytterhoeven wrote:
> Hi Arnd,
>
> On Wed, May 4, 2022 at 2:25 PM Arnd Bergmann <[email protected]> wrote:
>> On Wed, May 4, 2022 at 11:14 AM kernel test robot <[email protected]> wrote:
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>> head: 107c948d1d3e61d10aee9d0f7c3d81bbee9842af
>>> commit: 8b22820efb35f93d98638563b0a8f4094e8ee399 m68k: m68328: remove duplicate code
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <[email protected]>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl':
>>>>> time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll'
>>> m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll'
>>> m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll'
>>>
>>
>> I think this is just another build failure that was hidden before my patch,
>> not caused by my patch.
>
> That's an m68knommu kernel build with CONFIG_RTC_DRV_GENERIC=y,
> I guess?
CONFIG_RTC_DRV_GENERIC=m
--
~Randy