2024-05-31 23:29:39

by Dr. David Alan Gilbert

Subject: [PATCH] net: caif: remove unused structs

From: "Dr. David Alan Gilbert" <[email protected]>

'cfpktq' has been unused since
commit 73d6ac633c6c ("caif: code cleanup").

'caif_packet_funcs' is declared but never defined.

Remove both of them.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
include/net/caif/caif_layer.h | 2 --
net/caif/cfpkt_skbuff.c | 7 -------
2 files changed, 9 deletions(-)

diff --git a/include/net/caif/caif_layer.h b/include/net/caif/caif_layer.h
index 51f7bb42a936..0f45d875905f 100644
--- a/include/net/caif/caif_layer.h
+++ b/include/net/caif/caif_layer.h
@@ -11,9 +11,7 @@

struct cflayer;
struct cfpkt;
-struct cfpktq;
struct caif_payload_info;
-struct caif_packet_funcs;

#define CAIF_LAYER_NAME_SZ 16

diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c
index 7796414d47e5..2ae8cfa3df88 100644
--- a/net/caif/cfpkt_skbuff.c
+++ b/net/caif/cfpkt_skbuff.c
@@ -21,13 +21,6 @@ do { \
pr_warn(errmsg); \
} while (0)

-struct cfpktq {
- struct sk_buff_head head;
- atomic_t count;
- /* Lock protects count updates */
- spinlock_t lock;
-};
-
/*
* net/caif/ is generic and does not
* understand SKB, so we do this typecast
--
2.45.1

2024-06-01 00:20:19

by Jacob Keller

Subject: Re: [PATCH] net: caif: remove unused structs

On 5/31/2024 4:29 PM, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'cfpktq' has been unused since
> commit 73d6ac633c6c ("caif: code cleanup").
>
> 'caif_packet_funcs' is declared but never defined.
>
> Remove both of them.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---

Reviewed-by: Jacob Keller <[email protected]>

2024-06-05 09:20:50

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: caif: remove unused structs

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Sat, 1 Jun 2024 00:29:17 +0100 you wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'cfpktq' has been unused since
> commit 73d6ac633c6c ("caif: code cleanup").
>
> 'caif_packet_funcs' is declared but never defined.
>
> [...]

Here is the summary with links:
- net: caif: remove unused structs
https://git.kernel.org/netdev/net-next/c/6f49c3fb563c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html