2007-01-10 08:58:08

by Gerd Hoffmann

[permalink] [raw]
Subject: [patch] Fix bttv and friends on 64bit machines with lots of memory.

Fix bttv and friends on 64bit machines with lots of memory.

We have a DMA32 zone now, lets use it to make sure the card
can reach the memory we have allocated for the video frame
buffers.

Signed-off-by: Gerds Hoffmann <[email protected]>
---
drivers/media/video/video-buf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.18/drivers/media/video/video-buf.c
===================================================================
--- linux-2.6.18.orig/drivers/media/video/video-buf.c
+++ linux-2.6.18/drivers/media/video/video-buf.c
@@ -1224,7 +1224,7 @@ videobuf_vm_nopage(struct vm_area_struct
vaddr,vma->vm_start,vma->vm_end);
if (vaddr > vma->vm_end)
return NOPAGE_SIGBUS;
- page = alloc_page(GFP_USER);
+ page = alloc_page(GFP_USER | __GFP_DMA32);
if (!page)
return NOPAGE_OOM;
clear_user_page(page_address(page), vaddr, page);


Attachments:
v4l-dma32 (870.00 B)

2007-01-10 23:42:57

by hermann pitton

[permalink] [raw]
Subject: Re: [patch] Fix bttv and friends on 64bit machines with lots of memory.

Am Mittwoch, den 10.01.2007, 09:58 +0100 schrieb Gerd Hoffmann:
> Hi,
>
> We have a DMA32 zone now, lets use it to make sure the card
> can reach the memory we have allocated for the video frame
> buffers.
>
> please apply,
>
> Gerd

Hi,

did anybody already pick up, comment, review Gerd's patch ?

Walks in into his own home like a stranger ...

Gerd, THANKS for all you did.
It was a incredible lot!

Hermann

> einfaches Textdokument-Anlage (v4l-dma32)
> Fix bttv and friends on 64bit machines with lots of memory.
>
> We have a DMA32 zone now, lets use it to make sure the card
> can reach the memory we have allocated for the video frame
> buffers.
>
> Signed-off-by: Gerds Hoffmann <[email protected]>
> ---
> drivers/media/video/video-buf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.18/drivers/media/video/video-buf.c
> ===================================================================
> --- linux-2.6.18.orig/drivers/media/video/video-buf.c
> +++ linux-2.6.18/drivers/media/video/video-buf.c
> @@ -1224,7 +1224,7 @@ videobuf_vm_nopage(struct vm_area_struct
> vaddr,vma->vm_start,vma->vm_end);
> if (vaddr > vma->vm_end)
> return NOPAGE_SIGBUS;
> - page = alloc_page(GFP_USER);
> + page = alloc_page(GFP_USER | __GFP_DMA32);
> if (!page)
> return NOPAGE_OOM;
> clear_user_page(page_address(page), vaddr, page);

2007-01-13 00:42:42

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [patch] Fix bttv and friends on 64bit machines with lots of memory.

Em Qui, 2007-01-11 ?s 00:41 +0100, hermann pitton escreveu:
> Am Mittwoch, den 10.01.2007, 09:58 +0100 schrieb Gerd Hoffmann:
> > Hi,
> >
> > We have a DMA32 zone now, lets use it to make sure the card
> > can reach the memory we have allocated for the video frame
> > buffers.
> >
> > please apply,
> >
> > Gerd
>
> Hi,
>
> did anybody already pick up, comment, review Gerd's patch ?
>
> Walks in into his own home like a stranger ...
>
> Gerd, THANKS for all you did.
> It was a incredible lot!

Hermann,

I just picked it today. I was out this week due to a physical damage at
the hd on my notebook, were my mailboxes are retrieved. Only today I
have it on a stable condition to return back to activities, successfully
recovering my /home on it.


2007-01-13 01:38:30

by hermann pitton

[permalink] [raw]
Subject: Re: [patch] Fix bttv and friends on 64bit machines with lots of memory.

Am Freitag, den 12.01.2007, 22:42 -0200 schrieb Mauro Carvalho Chehab:
> Em Qui, 2007-01-11 às 00:41 +0100, hermann pitton escreveu:
> > Am Mittwoch, den 10.01.2007, 09:58 +0100 schrieb Gerd Hoffmann:
> > > Hi,
> > >
> > > We have a DMA32 zone now, lets use it to make sure the card
> > > can reach the memory we have allocated for the video frame
> > > buffers.
> > >
> > > please apply,
> > >
> > > Gerd
> >
> > Hi,
> >
> > did anybody already pick up, comment, review Gerd's patch ?
> >
> > Walks in into his own home like a stranger ...
> >
> > Gerd, THANKS for all you did.
> > It was a incredible lot!
>
> Hermann,
>
> I just picked it today. I was out this week due to a physical damage at
> the hd on my notebook, were my mailboxes are retrieved. Only today I
> have it on a stable condition to return back to activities, successfully
> recovering my /home on it.

Mauro, Gerd,

sorry to be a pain with this one,
just thought it could be a missing each other.

Our maintainers don't need to excuse for anything!

Adrian and all, thanks for fixing the remaining bugs.

Cheers,
Hermann