$ grep -r DE_AOC .
./.config:CONFIG_DE_AOC=y
./drivers/isdn/hisax/l3dss1.c:#ifdef HISAX_DE_AOC
./drivers/isdn/hisax/l3dss1.c:#else /* not HISAX_DE_AOC */
./drivers/isdn/hisax/l3dss1.c:#endif /* not HISAX_DE_AOC */
./drivers/isdn/hisax/Kconfig:config DE_AOC
it seems like there's a name mismatch between the config variable
and the one that's being tested, no?
OTOH, since that code *is* in the allegedly obsolete old ISDN4Linux
code, perhaps that entire part of the tree can just be junked. but if
it's sticking around, it should probably be fixed.
unless i'm misreading something up there.
rday
On Mon, Jan 15, 2007 at 06:43:30AM -0500, Robert P. J. Day wrote:
>
> $ grep -r DE_AOC .
> ./.config:CONFIG_DE_AOC=y
> ./drivers/isdn/hisax/l3dss1.c:#ifdef HISAX_DE_AOC
> ./drivers/isdn/hisax/l3dss1.c:#else /* not HISAX_DE_AOC */
> ./drivers/isdn/hisax/l3dss1.c:#endif /* not HISAX_DE_AOC */
> ./drivers/isdn/hisax/Kconfig:config DE_AOC
>
> it seems like there's a name mismatch between the config variable
> and the one that's being tested, no?
>
> OTOH, since that code *is* in the allegedly obsolete old ISDN4Linux
> code, perhaps that entire part of the tree can just be junked. but if
> it's sticking around, it should probably be fixed.
>
Yes thanks for discover this. Since the code only affect the
analyse of the AOC info which is pure information only without real
function it was not detected before.
--
Karsten Keil
SuSE Labs
ISDN development
Robert P. J. Day schrieb:
> OTOH, since that code *is* in the allegedly obsolete old ISDN4Linux
> code, perhaps that entire part of the tree can just be junked. but if
> it's sticking around, it should probably be fixed.
Please do not remove isdn4linux just yet. It's true that it has been
marked as obsolete for quite some time, but it's still needed anyway.
Its designated successor, the CAPI subsystem, so far only supports
a very limited range of hardware. Dropping isdn4linux now would leave
the owners of some very popular ISDN cards out in the cold.
Thanks,
Tilman
--
Tilman Schmidt E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Unge?ffnet mindestens haltbar bis: (siehe R?ckseite)
On Mon, 15 Jan 2007, Tilman Schmidt wrote:
> Robert P. J. Day schrieb:
> > OTOH, since that code *is* in the allegedly obsolete old ISDN4Linux
> > code, perhaps that entire part of the tree can just be junked. but if
> > it's sticking around, it should probably be fixed.
>
> Please do not remove isdn4linux just yet. It's true that it has been
> marked as obsolete for quite some time, but it's still needed
> anyway. Its designated successor, the CAPI subsystem, so far only
> supports a very limited range of hardware. Dropping isdn4linux now
> would leave the owners of some very popular ISDN cards out in the
> cold.
that wouldn't be my decision, i just made a note of an oddity. but if
it's still in actual use, then it really should be re-labelled from
"obsolete" to "deprecated," no?
rday
On Mon, Jan 15, 2007 at 12:17:37PM -0500, Robert P. J. Day wrote:
> On Mon, 15 Jan 2007, Tilman Schmidt wrote:
>
> > Robert P. J. Day schrieb:
> > > OTOH, since that code *is* in the allegedly obsolete old ISDN4Linux
> > > code, perhaps that entire part of the tree can just be junked. but if
> > > it's sticking around, it should probably be fixed.
> >
> > Please do not remove isdn4linux just yet. It's true that it has been
> > marked as obsolete for quite some time, but it's still needed
> > anyway. Its designated successor, the CAPI subsystem, so far only
> > supports a very limited range of hardware. Dropping isdn4linux now
> > would leave the owners of some very popular ISDN cards out in the
> > cold.
>
> that wouldn't be my decision, i just made a note of an oddity. but if
> it's still in actual use, then it really should be re-labelled from
> "obsolete" to "deprecated," no?
>
Good point.
--
Karsten Keil
SuSE Labs
ISDN development
Am 15.01.2007 18:29 schrieb Karsten Keil:
> On Mon, Jan 15, 2007 at 12:17:37PM -0500, Robert P. J. Day wrote:
>> [...] but if
>> it's still in actual use, then it really should be re-labelled from
>> "obsolete" to "deprecated," no?
>
> Good point.
May I?
From: Tilman Schmidt <[email protected]>
Remove incorrect "obsolete" label from ISDN4Linux
---
--- a/drivers/isdn/Kconfig 2006-11-29 22:57:37.000000000 +0100
+++ b/drivers/isdn/Kconfig 2007-02-21 01:19:19.000000000 +0100
@@ -25,7 +25,7 @@ menu "Old ISDN4Linux"
depends on NET && ISDN
config ISDN_I4L
- tristate "Old ISDN4Linux (obsolete)"
+ tristate "Old ISDN4Linux subsystem"
---help---
This driver allows you to use an ISDN-card for networking
connections and as dialin/out device. The isdn-tty's have a built
@@ -38,8 +38,8 @@ config ISDN_I4L
ISDN support in the linux kernel is moving towards a new API,
called CAPI (Common ISDN Application Programming Interface).
- Therefore the old ISDN4Linux layer is becoming obsolete. It is
- still usable, though, if you select this option.
+ The old ISDN4Linux layer is still available for use with cards
+ that are not supported by the new CAPI subsystem yet.
if ISDN_I4L
source "drivers/isdn/i4l/Kconfig"
--
Tilman Schmidt E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Unge?ffnet mindestens haltbar bis: (siehe R?ckseite)
Seeing that the discussion about this has ebbed out but the last version
of this patch has disappeared again from the -mm tree, permit me another
attempt to get this fixed:
From: Tilman Schmidt <[email protected]>
According to the definitions recently posted on LKML, the maturity label
for the ISDN4Linux subsystem is wrong. This patch corrects it and also
clarifies the accompanying help text a bit.
Signed-off-by: Tilman Schmidt <[email protected]>
---
--- a/drivers/isdn/Kconfig 2007-02-04 19:44:54.000000000 +0100
+++ b/drivers/isdn/Kconfig 2007-05-28 14:48:54.000000000 +0200
@@ -25,9 +25,9 @@ menu "Old ISDN4Linux"
depends on NET && ISDN
config ISDN_I4L
- tristate "Old ISDN4Linux (obsolete)"
+ tristate "Old ISDN4Linux (deprecated)"
---help---
- This driver allows you to use an ISDN-card for networking
+ This subsystem allows you to use an ISDN adapter for networking
connections and as dialin/out device. The isdn-tty's have a built
in AT-compatible modem emulator. Network devices support autodial,
channel-bundling, callback and caller-authentication without having
@@ -38,8 +38,9 @@ config ISDN_I4L
ISDN support in the linux kernel is moving towards a new API,
called CAPI (Common ISDN Application Programming Interface).
- Therefore the old ISDN4Linux layer is becoming obsolete. It is
- still usable, though, if you select this option.
+ Therefore the old ISDN4Linux layer will eventually become obsolete.
+ It is still available, though, for use with adapters that are not
+ supported by the new CAPI subsystem yet.
if ISDN_I4L
source "drivers/isdn/i4l/Kconfig"
--
Tilman Schmidt E-Mail: [email protected]
Bonn, Germany
In theory, there is no difference between theory and practice.
In practice, there is.