2002-03-20 21:38:04

by Cameron, Steve

[permalink] [raw]

Subject: RE: Hooks for random device entropy generation missing incpqarray.c

---

> excuse me I am using 2.4.18
>

Ok. If SA_SAMPLE_RANDOM is not in
the call to request_irq, you can put
it in. A trivial (but untested) patch:
(if outlook doesn't mangle it)

-- steve

--- cpqarray.c.orig Wed Mar 20 15:25:51 2002
+++ cpqarray.c Wed Mar 20 15:26:30 2002
@@ -516,8 +516,9 @@


hba[i]->access.set_intr_mask(hba[i], 0);
- if (request_irq(hba[i]->intr, do_ida_intr,
- SA_INTERRUPT|SA_SHIRQ, hba[i]->devname, hba[i]))
+ if (request_irq(hba[i]->intr, do_ida_intr,
+ SA_SAMPLE_RANDOM|SA_INTERRUPT|SA_SHIRQ,
+ hba[i]->devname, hba[i]))
{

printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n",

2002-03-20 21:50:05

by Manon Goo

[permalink] [raw]

Subject: RE: Hooks for random device entropy generation missing incpqarray.c

---

I have not tried your patch. but this is in cpqarray_init() and it is only
called when the driver is initilaized.
How is the entropy-pool further updated ?

Thanks

Manon



--On Mittwoch, 20. M?rz 2002 15:37 Uhr -0600 "Cameron, Steve"
<[email protected]> wrote:

>
>> excuse me I am using 2.4.18
>>
>
> Ok. If SA_SAMPLE_RANDOM is not in
> the call to request_irq, you can put
> it in. A trivial (but untested) patch:
> (if outlook doesn't mangle it)
>
> -- steve
>
> --- cpqarray.c.orig Wed Mar 20 15:25:51 2002
> +++ cpqarray.c Wed Mar 20 15:26:30 2002
> @@ -516,8 +516,9 @@
>
>
> hba[i]->access.set_intr_mask(hba[i], 0);
> - if (request_irq(hba[i]->intr, do_ida_intr,
> - SA_INTERRUPT|SA_SHIRQ, hba[i]->devname, hba[i]))
> + if (request_irq(hba[i]->intr, do_ida_intr,
> + SA_SAMPLE_RANDOM|SA_INTERRUPT|SA_SHIRQ,
> + hba[i]->devname, hba[i]))
> {
>
> printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n",
>
>

---

Attachments:

(No filename) (942.00 B)
(No filename) (229.00 B)
Download all attachments