2007-01-27 08:31:28

by Robert P. J. Day

[permalink] [raw]
Subject: definite OMAP1610_IR-related typo


not sure what to do with this, it's all yours:

========== OMAP1610_IR ==========
./arch/arm/mach-omap1/devices.c:#if defined(CONFIG_OMAP1610_IR) || defined(CONFIG_OMAP161O_IR_MODULE)
========== OMAP161O_IR ==========
./arch/arm/mach-omap1/devices.c:#if defined(CONFIG_OMAP1610_IR) || defined(CONFIG_OMAP161O_IR_MODULE)

note first that one of those config vars has an "oh" while the other
has a *zero*. i'm pretty sure that's bad.

in any event, there's no such config variable of *either* spelling
in any Kconfig file, but there *is* a more all-encompassing
CONFIG_OMAP16XX confguration setting.

--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================


2007-01-28 07:13:08

by Dirk Behme

[permalink] [raw]
Subject: Re: definite OMAP1610_IR-related typo

Robert P. J. Day wrote at LKML:
> not sure what to do with this, it's all yours:
>
> ========== OMAP1610_IR ==========
> ./arch/arm/mach-omap1/devices.c:#if
defined(CONFIG_OMAP1610_IR) ||
> defined(CONFIG_OMAP161O_IR_MODULE)
> ========== OMAP161O_IR ==========
> ./arch/arm/mach-omap1/devices.c:#if
defined(CONFIG_OMAP1610_IR) ||
> defined(CONFIG_OMAP161O_IR_MODULE)
>
> note first that one of those config vars has an "oh"
while the other
> has a *zero*. i'm pretty sure that's bad.
>
> in any event, there's no such config variable of *either*
spelling
> in any Kconfig file, but there *is* a more all-encompassing
> CONFIG_OMAP16XX confguration setting.

This is fixed in recent OMAP git tree and OMAP patches we
prepared for upstream. Can you try OMAP patches 4113, 4114,
4115 and 4116 to be found in RMKs patch system [1]? Or, even
better, use current OMAP git [2]?

Regards

Dirk

P.S. #1: Would be nice to CC OMAP list [3] next time as well.

P.S. #2: Sorry if mail references are wrong, I'm currently
not subscribed to LKML.

[1]
http://www.arm.linux.org.uk/developer/patches/section.php?section=0

[2]
http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=summary

[3]
http://linux.omap.com/mailman/listinfo/linux-omap-open-source