2007-01-25 23:06:11

by Robert P. J. Day

Subject: [PATCH] Fix "CONFIG_X86_64_" typo in drivers/kvm/svm.c.

Fix what looks like an obvious typo in the file drivers/kvm/svm.c.

Signed-off-by: Robert P. J. Day <[email protected]>

---

is this, in fact, a typo?

diff --git a/drivers/kvm/svm.c b/drivers/kvm/svm.c
index 7397bfb..1764fb6 100644
--- a/drivers/kvm/svm.c
+++ b/drivers/kvm/svm.c
@@ -1149,7 +1149,7 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 data)
case MSR_K6_STAR:
vcpu->svm->vmcb->save.star = data;
break;
-#ifdef CONFIG_X86_64_
+#ifdef CONFIG_X86_64
case MSR_LSTAR:
vcpu->svm->vmcb->save.lstar = data;
break;

--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================

2007-01-28 13:01:19

by Avi Kivity

Subject: Re: [PATCH] Fix "CONFIG_X86_64_" typo in drivers/kvm/svm.c.

Robert P. J. Day wrote:
> Fix what looks like an obvious typo in the file drivers/kvm/svm.c.
>
> Signed-off-by: Robert P. J. Day <[email protected]>
>
> ---
>
> is this, in fact, a typo?
>
>

It is. Well spotted.

I tested this on my AMD machine, and everything still works.

Acked-by: Avi Kivity <[email protected]>



> diff --git a/drivers/kvm/svm.c b/drivers/kvm/svm.c
> index 7397bfb..1764fb6 100644
> --- a/drivers/kvm/svm.c
> +++ b/drivers/kvm/svm.c
> @@ -1149,7 +1149,7 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 data)
> case MSR_K6_STAR:
> vcpu->svm->vmcb->save.star = data;
> break;
> -#ifdef CONFIG_X86_64_
> +#ifdef CONFIG_X86_64
> case MSR_LSTAR:
> vcpu->svm->vmcb->save.lstar = data;
> break;
>
>


--
error compiling committee.c: too many arguments to function