2007-02-15 09:36:33

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] x86: Unify pcspeaker platform device code between i386/x86-64

Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=62cc49396e593dd71c6595302bb10b085aefbfa5
> Commit: 62cc49396e593dd71c6595302bb10b085aefbfa5
> Parent: 40d22c1b5675e428b3f3f9a945d0bd62e94ca2f1
> Author: Andi Kleen <[email protected]>
> AuthorDate: Tue Feb 13 13:26:26 2007 +0100
> Committer: Andi Kleen <[email protected]>
> CommitDate: Tue Feb 13 13:26:26 2007 +0100
>
> [PATCH] x86: Unify pcspeaker platform device code between i386/x86-64
>
> Trivial cleanup.
>
> Only change is that it is always compiled in now on x86-64 like on i386.
>
> Signed-off-by: Andi Kleen <[email protected]>

THANK YOU.

It's always seemed broken (though perhaps this was a distro bug?) in
module form, so I've been compiling it in to get it to work.

Jeff



2007-02-15 09:58:28

by Andi Kleen

[permalink] [raw]
Subject: Re: [PATCH] x86: Unify pcspeaker platform device code between i386/x86-64


> It's always seemed broken (though perhaps this was a distro bug?) in
> module form, so I've been compiling it in to get it to work.

Must have been a distro bug. It should have worked before as long
as the config was enabled.

-Andi

2007-02-15 11:19:31

by Dave Jones

[permalink] [raw]
Subject: Re: [PATCH] x86: Unify pcspeaker platform device code between i386/x86-64

On Thu, Feb 15, 2007 at 10:49:57AM +0100, Andi Kleen wrote:
>
> > It's always seemed broken (though perhaps this was a distro bug?) in
> > module form, so I've been compiling it in to get it to work.
>
> Must have been a distro bug. It should have worked before as long
> as the config was enabled.

If so, I'm not sure what distro Jeff was running, as it worked
fine in Fedora for some time on both 32bit and 64bit x86 for me.

Dave

--
http://www.codemonkey.org.uk

2007-02-15 11:28:37

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] x86: Unify pcspeaker platform device code between i386/x86-64

Dave Jones wrote:
> On Thu, Feb 15, 2007 at 10:49:57AM +0100, Andi Kleen wrote:
> >
> > > It's always seemed broken (though perhaps this was a distro bug?) in
> > > module form, so I've been compiling it in to get it to work.
> >
> > Must have been a distro bug. It should have worked before as long
> > as the config was enabled.
>
> If so, I'm not sure what distro Jeff was running, as it worked
> fine in Fedora for some time on both 32bit and 64bit x86 for me.

Fedora's always had this problem for me, on most if not all the active
computers in my lab :) Maybe my house is over a magetic ley line or
something :)

Jeff