2007-02-22 03:11:55

by Andrew Morton

[permalink] [raw]
Subject: Re: [patch 18/24] Xen-paravirt_ops: Some generic early printk & boot console fixups

On Wed, 21 Feb 2007 12:53:12 -0800 Jeremy Fitzhardinge <[email protected]> wrote:

> Some generic early printk & boot console fixups
> (already sent to lkml).

hm, this patch series seems to have gone out of its way to cause problems.

This particular (pathetically changelogged) patch is already in my tree,
only in a later, much more comprehensive form. Similarly the HVC changes
were already in Rusty's stuff and were supposed to be merged by Paulus, but
haven't been yet.

Can we just drop this one? Does the Xen work actually depend on it?


2007-02-22 05:48:14

by Jeremy Fitzhardinge

[permalink] [raw]
Subject: Re: [patch 18/24] Xen-paravirt_ops: Some generic early printk & boot console fixups

Andrew Morton wrote:
> hm, this patch series seems to have gone out of its way to cause problems.
>
> This particular (pathetically changelogged) patch is already in my tree,
> only in a later, much more comprehensive form. Similarly the HVC changes
> were already in Rusty's stuff and were supposed to be merged by Paulus, but
> haven't been yet.
>
> Can we just drop this one? Does the Xen work actually depend on it?

Well, some form of the hvc patches is needed to get a console. I'll
rationalize them with respect to Gerd and Rusty's latest patches, but I
did want to make the series stand on its own rather than have external
dependencies on unmerged patches.

J

2007-02-22 08:33:16

by Gerd Hoffmann

[permalink] [raw]
Subject: Re: [patch 18/24] Xen-paravirt_ops: Some generic early printk & boot console fixups

Jeremy Fitzhardinge wrote:
> Andrew Morton wrote:
>> hm, this patch series seems to have gone out of its way to cause problems.
>>
>> This particular (pathetically changelogged) patch is already in my tree,
>> only in a later, much more comprehensive form. Similarly the HVC changes
>> were already in Rusty's stuff and were supposed to be merged by Paulus, but
>> haven't been yet.
>>
>> Can we just drop this one? Does the Xen work actually depend on it?

Yes. The other which made it into -mm via lkml is a more recent version
of the same patch (+documentation, +!x86 arch updates).

On the hvm_console.c changes: there is just a small change needed to
make it build on !ppc, that should be identical identical in my (xen)
and rusty (lguest) patch series. Patching it only once is fine for
obvious reasons ;)

cheers,
Gerd

--
Gerd Hoffmann <[email protected]>