2021-02-04 23:44:21

by Denis Efremov (Oracle)

[permalink] [raw]
Subject: [GIT PULL] Floppy patch for 5.12

The following changes since commit 0d7389718c32ad6bb8bee7895c91e2418b6b26aa:

Merge tag 'nvme-5.21-2020-02-02' of git://git.infradead.org/nvme into for-5.12/drivers (2021-02-02 07:11:47 -0700)

are available in the Git repository at:

https://github.com/evdenis/linux-floppy tags/floppy-for-5.12

for you to fetch changes up to 8a0c014cd20516ade9654fc13b51345ec58e7be8:

floppy: reintroduce O_NDELAY fix (2021-02-04 13:00:24 +0300)

----------------------------------------------------------------
Floppy patch for 5.12

- O_NDELAY/O_NONBLOCK fix for floppy from Jiri Kosina.
libblkid is using O_NONBLOCK when probing devices.
This leads to pollution of kernel log with error
messages from floppy driver. Also the driver fails
a mount prior to being opened without O_NONBLOCK
at least once. The patch fixes the issues.

Signed-off-by: Denis Efremov <[email protected]>

----------------------------------------------------------------
Jiri Kosina (1):
floppy: reintroduce O_NDELAY fix

drivers/block/floppy.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)


2021-02-05 00:33:18

by Jens Axboe

[permalink] [raw]
Subject: Re: [GIT PULL] Floppy patch for 5.12

On 2/4/21 3:12 AM, Denis Efremov wrote:
> The following changes since commit 0d7389718c32ad6bb8bee7895c91e2418b6b26aa:
>
> Merge tag 'nvme-5.21-2020-02-02' of git://git.infradead.org/nvme into for-5.12/drivers (2021-02-02 07:11:47 -0700)
>
> are available in the Git repository at:
>
> https://github.com/evdenis/linux-floppy tags/floppy-for-5.12

Pulled, thanks.

--
Jens Axboe

2021-02-05 00:43:13

by Kurt Garloff

[permalink] [raw]
Subject: Re: [GIT PULL] Floppy patch for 5.12

Hi Jens,

Am 04.02.21 um 15:37 schrieb Jens Axboe:
> On 2/4/21 3:12 AM, Denis Efremov wrote:
>> The following changes since commit 0d7389718c32ad6bb8bee7895c91e2418b6b26aa:
>>
>> Merge tag 'nvme-5.21-2020-02-02' of git://git.infradead.org/nvme into for-5.12/drivers (2021-02-02 07:11:47 -0700)
>>
>> are available in the Git repository at:
>>
>> https://github.com/evdenis/linux-floppy tags/floppy-for-5.12
> Pulled, thanks.

Great, thanks!

Next is -stable then ... so all those cloud images using floppy to inject metadata
work again, despite current libblkid.
(Fortunately, most use cdrom these days.)

Best,

--
Kurt Garloff <[email protected]>, Cologne, Germany

2021-02-05 09:10:46

by Jiri Kosina

[permalink] [raw]
Subject: Re: [GIT PULL] Floppy patch for 5.12

On Thu, 4 Feb 2021, Kurt Garloff wrote:

> >> The following changes since commit 0d7389718c32ad6bb8bee7895c91e2418b6b26aa:
> >>
> >> Merge tag 'nvme-5.21-2020-02-02' of git://git.infradead.org/nvme into for-5.12/drivers (2021-02-02 07:11:47 -0700)
> >>
> >> are available in the Git repository at:
> >>
> >> https://github.com/evdenis/linux-floppy tags/floppy-for-5.12
> > Pulled, thanks.
>
> Great, thanks!
>
> Next is -stable then ... so all those cloud images using floppy to
> inject metadata work again, despite current libblkid. (Fortunately, most
> use cdrom these days.)

-stable we can do only after the commit lands in Linus' tree.

Once that happens, I believe we can just as the version we have in
openSUSE 15.2 kernel for now as-is:

https://github.com/openSUSE/kernel-source/commit/ab10a7db5f5b721bf2145e6eab9358a751dd0e5b

--
Jiri Kosina
SUSE Labs