2022-11-18 18:54:08

by Melody Olvera

[permalink] [raw]
Subject: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes

Update the bindings to allow for generic regulator nodes instead of
device-specific node names.

Signed-off-by: Melody Olvera <[email protected]>
---
This patch comes from discussions on [1] and is separated out. It also
has updated pattern matching to match the comments left from [1].

[1] https://lore.kernel.org/all/[email protected]/

Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
index b246500d3d5d..23ee56bfa636 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
@@ -112,8 +112,9 @@ properties:
$ref: /schemas/power/qcom,rpmpd.yaml#

patternProperties:
- '-regulators$':
+ '^regulators(-[01])?$':
$ref: /schemas/regulator/qcom,rpmh-regulator.yaml#
+ unevaluatedProperties: false

required:
- compatible

base-commit: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67
--
2.38.1



2022-11-21 10:36:44

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes

On 18/11/2022 19:25, Melody Olvera wrote:
> Update the bindings to allow for generic regulator nodes instead of
> device-specific node names.
>
> Signed-off-by: Melody Olvera <[email protected]>
> ---


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2022-11-22 12:05:06

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes

On 21/11/2022 11:27, Krzysztof Kozlowski wrote:
> On 18/11/2022 19:25, Melody Olvera wrote:
>> Update the bindings to allow for generic regulator nodes instead of
>> device-specific node names.
>>
>> Signed-off-by: Melody Olvera <[email protected]>
>> ---
>
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Unreviewed, because this should include also SM8550, otherwise a new
patch will follow it immediately, which is not necessary.

On SM8550 the apps_rsc node has up to 6 PMICs, so it should be instead:
'^regulators(-[0-9])?$':

Best regards,
Krzysztof

2022-11-22 17:27:11

by Melody Olvera

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: qcom,rpmh-rsc: Update to allow for generic nodes



On 11/22/2022 5:41 AM, Krzysztof Kozlowski wrote:
> On 21/11/2022 11:27, Krzysztof Kozlowski wrote:
>> On 18/11/2022 19:25, Melody Olvera wrote:
>>> Update the bindings to allow for generic regulator nodes instead of
>>> device-specific node names.
>>>
>>> Signed-off-by: Melody Olvera <[email protected]>
>>> ---
>>
>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Unreviewed, because this should include also SM8550, otherwise a new
> patch will follow it immediately, which is not necessary.
>
> On SM8550 the apps_rsc node has up to 6 PMICs, so it should be instead:
> '^regulators(-[0-9])?$':

Sure thing.

Thanks,
Melody

> Best regards,
> Krzysztof
>