LinuxLists.cc - arch/powerpc/mm/nohash/fsl_book3e.c:61:3: sparse: sparse: symbol 'tlbcam_addrs' was not declared. Should it be static?

2022-03-14 05:51:59

Subject: arch/powerpc/mm/nohash/fsl_book3e.c:61:3: sparse: sparse: symbol 'tlbcam_addrs' was not declared. Should it be static?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: aad611a868d16cdc16a7d4a764cef955293e47e3
commit: 44c14509b0dabb909ad1ec28800893ea71762732 powerpc/fsl_booke: Fix setting of exec flag when setting TLBCAMs
date: 5 months ago
config: powerpc-randconfig-s031-20220313 (https://download.01.org/0day-ci/archive/20220314/[email protected]/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=44c14509b0dabb909ad1ec28800893ea71762732
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 44c14509b0dabb909ad1ec28800893ea71762732
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/mm/nohash/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

sparse warnings: (new ones prefixed by >>)
>> arch/powerpc/mm/nohash/fsl_book3e.c:61:3: sparse: sparse: symbol 'tlbcam_addrs' was not declared. Should it be static?
arch/powerpc/mm/nohash/fsl_book3e.c:63:15: sparse: sparse: symbol 'tlbcam_sz' was not declared. Should it be static?
>> arch/powerpc/mm/nohash/fsl_book3e.c:277:30: sparse: sparse: Using plain integer as NULL pointer

vim +/tlbcam_addrs +61 arch/powerpc/mm/nohash/fsl_book3e.c

14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 53
78f622377f7d31 arch/powerpc/mm/fsl_booke_mmu.c Kumar Gala 2010-05-13 54 #define NUM_TLBCAMS (64)
78f622377f7d31 arch/powerpc/mm/fsl_booke_mmu.c Kumar Gala 2010-05-13 @55 struct tlbcam TLBCAM[NUM_TLBCAMS];
14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 56
14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 57 struct tlbcamrange {
14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 58 unsigned long start;
14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 59 unsigned long limit;
14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 60 phys_addr_t phys;
14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 @61 } tlbcam_addrs[NUM_TLBCAMS];
14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 62

:::::: The code at line 61 was first introduced by commit
:::::: 14cf11af6cf608eb8c23e989ddb17a715ddce109 powerpc: Merge enough to start building in arch/powerpc.

:::::: TO: Paul Mackerras <[email protected]>
:::::: CC: Paul Mackerras <[email protected]>

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/[email protected]

2022-03-14 12:35:16

by Christophe Leroy

[permalink] [raw]

Subject: Re: arch/powerpc/mm/nohash/fsl_book3e.c:61:3: sparse: sparse: symbol 'tlbcam_addrs' was not declared. Should it be static?

Le 13/03/2022 à 19:29, kernel test robot a écrit :
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: aad611a868d16cdc16a7d4a764cef955293e47e3
> commit: 44c14509b0dabb909ad1ec28800893ea71762732 powerpc/fsl_booke: Fix setting of exec flag when setting TLBCAMs

This problem as likely always existed. There is absolutely no link with
the above commit.

> date: 5 months ago
> config: powerpc-randconfig-s031-20220313 (https://download.01.org/0day-ci/archive/20220314/[email protected]/config)
> compiler: powerpc-linux-gcc (GCC) 11.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.4-dirty
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=44c14509b0dabb909ad1ec28800893ea71762732
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 44c14509b0dabb909ad1ec28800893ea71762732
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/mm/nohash/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
>
> sparse warnings: (new ones prefixed by >>)
>>> arch/powerpc/mm/nohash/fsl_book3e.c:61:3: sparse: sparse: symbol 'tlbcam_addrs' was not declared. Should it be static?
> arch/powerpc/mm/nohash/fsl_book3e.c:63:15: sparse: sparse: symbol 'tlbcam_sz' was not declared. Should it be static?
>>> arch/powerpc/mm/nohash/fsl_book3e.c:277:30: sparse: sparse: Using plain integer as NULL pointer
>
> vim +/tlbcam_addrs +61 arch/powerpc/mm/nohash/fsl_book3e.c
>
> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 53
> 78f622377f7d31 arch/powerpc/mm/fsl_booke_mmu.c Kumar Gala 2010-05-13 54 #define NUM_TLBCAMS (64)
> 78f622377f7d31 arch/powerpc/mm/fsl_booke_mmu.c Kumar Gala 2010-05-13 @55 struct tlbcam TLBCAM[NUM_TLBCAMS];
> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 56
> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 57 struct tlbcamrange {
> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 58 unsigned long start;
> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 59 unsigned long limit;
> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 60 phys_addr_t phys;
> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 @61 } tlbcam_addrs[NUM_TLBCAMS];
> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 62
>
> :::::: The code at line 61 was first introduced by commit
> :::::: 14cf11af6cf608eb8c23e989ddb17a715ddce109 powerpc: Merge enough to start building in arch/powerpc.
>
> :::::: TO: Paul Mackerras <[email protected]>
> :::::: CC: Paul Mackerras <[email protected]>
>
> ---
> 0-DAY CI Kernel Test Service
> https://lists.01.org/hyperkitty/list/[email protected]

2022-03-17 05:18:11

by Chen, Rong A

[permalink] [raw]

Subject: Re: [kbuild-all] Re: arch/powerpc/mm/nohash/fsl_book3e.c:61:3: sparse: sparse: symbol 'tlbcam_addrs' was not declared. Should it be static?

On 3/14/2022 2:49 AM, Christophe Leroy wrote:
>
>
> Le 13/03/2022 à 19:29, kernel test robot a écrit :
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: aad611a868d16cdc16a7d4a764cef955293e47e3
>> commit: 44c14509b0dabb909ad1ec28800893ea71762732 powerpc/fsl_booke: Fix setting of exec flag when setting TLBCAMs
>
> This problem as likely always existed. There is absolutely no link with
> the above commit.

Hi Christophe,

Thanks for the feedback, we checked the build results of commit 44c14509
and parent commit, the commit 44c14509 fixed a issue which triggered
sparse worked on fsl_book3e.c, so you are right, it's not related to the
above commit.

Best Regards,
Rong Chen

>
>> date: 5 months ago
>> config: powerpc-randconfig-s031-20220313 (https://download.01.org/0day-ci/archive/20220314/[email protected]/config)
>> compiler: powerpc-linux-gcc (GCC) 11.2.0
>> reproduce:
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # apt-get install sparse
>> # sparse version: v0.6.4-dirty
>> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=44c14509b0dabb909ad1ec28800893ea71762732
>> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> git fetch --no-tags linus master
>> git checkout 44c14509b0dabb909ad1ec28800893ea71762732
>> # save the config file to linux build tree
>> mkdir build_dir
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/mm/nohash/
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <[email protected]>
>>
>>
>> sparse warnings: (new ones prefixed by >>)
>>>> arch/powerpc/mm/nohash/fsl_book3e.c:61:3: sparse: sparse: symbol 'tlbcam_addrs' was not declared. Should it be static?
>> arch/powerpc/mm/nohash/fsl_book3e.c:63:15: sparse: sparse: symbol 'tlbcam_sz' was not declared. Should it be static?
>>>> arch/powerpc/mm/nohash/fsl_book3e.c:277:30: sparse: sparse: Using plain integer as NULL pointer
>>
>> vim +/tlbcam_addrs +61 arch/powerpc/mm/nohash/fsl_book3e.c
>>
>> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 53
>> 78f622377f7d31 arch/powerpc/mm/fsl_booke_mmu.c Kumar Gala 2010-05-13 54 #define NUM_TLBCAMS (64)
>> 78f622377f7d31 arch/powerpc/mm/fsl_booke_mmu.c Kumar Gala 2010-05-13 @55 struct tlbcam TLBCAM[NUM_TLBCAMS];
>> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 56
>> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 57 struct tlbcamrange {
>> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 58 unsigned long start;
>> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 59 unsigned long limit;
>> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 60 phys_addr_t phys;
>> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 @61 } tlbcam_addrs[NUM_TLBCAMS];
>> 14cf11af6cf608 arch/powerpc/mm/fsl_booke_mmu.c Paul Mackerras 2005-09-26 62
>>
>> :::::: The code at line 61 was first introduced by commit
>> :::::: 14cf11af6cf608eb8c23e989ddb17a715ddce109 powerpc: Merge enough to start building in arch/powerpc.
>>
>> :::::: TO: Paul Mackerras <[email protected]>
>> :::::: CC: Paul Mackerras <[email protected]>
>>
>> ---
>> 0-DAY CI Kernel Test Service
>> https://lists.01.org/hyperkitty/list/[email protected]
> _______________________________________________
> kbuild-all mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
>