2023-03-22 17:05:04

by Richard Weinberger

[permalink] [raw]
Subject: Re: [PATCH v3 05/10] ubifs: convert to kobject_del_and_put()

----- Ursprüngliche Mail -----
> Von: "Yangtao Li" <[email protected]>
> An: "richard" <[email protected]>
> CC: "Yangtao Li" <[email protected]>, "Greg Kroah-Hartman" <[email protected]>, "Rafael J. Wysocki"
> <[email protected]>, "Damien Le Moal" <[email protected]>, "linux-mtd" <[email protected]>,
> "linux-kernel" <[email protected]>
> Gesendet: Mittwoch, 22. März 2023 17:59:00
> Betreff: [PATCH v3 05/10] ubifs: convert to kobject_del_and_put()

> Use kobject_del_and_put() to simplify code.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Damien Le Moal <[email protected]>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> fs/ubifs/sysfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ubifs/sysfs.c b/fs/ubifs/sysfs.c
> index 1c958148bb87..9571718e61a9 100644
> --- a/fs/ubifs/sysfs.c
> +++ b/fs/ubifs/sysfs.c
> @@ -130,8 +130,7 @@ int ubifs_sysfs_register(struct ubifs_info *c)
>
> void ubifs_sysfs_unregister(struct ubifs_info *c)
> {
> - kobject_del(&c->kobj);
> - kobject_put(&c->kobj);
> + kobject_del_and_put(&c->kobj);
> wait_for_completion(&c->kobj_unregister);

Acked-by: Richard Weinberger <[email protected]>

Thanks,
//richard