Hello.
It seems hrtimer_forward was forgotten to
export - other symbols of the hrtimers API
are already exported.
Unless I am missing something, using the
hrtimers without that function is problematic.
Andrew, could you please apply?
Signed-off-by: <[email protected]>
On Thu, 2007-05-03 at 21:57 +0400, Stas Sergeev wrote:
> Hello.
>
> It seems hrtimer_forward was forgotten to
> export - other symbols of the hrtimers API
> are already exported.
> Unless I am missing something, using the
> hrtimers without that function is problematic.
>
> Andrew, could you please apply?
Are there actual in-tree users of this symbol? Without we usually leave
the symbol unexported, this saves some space.
Hello.
Peter Zijlstra wrote:
>> It seems hrtimer_forward was forgotten to
>> export - other symbols of the hrtimers API
> Are there actual in-tree users of this symbol? Without we usually leave
> the symbol unexported, this saves some space.
Do you mean it was really left intentional?
Unbeleivable! But why the other parts of a
hrtimer API are exported nevertheless, and
only this particular function not?
As for the users - I am porting my pcsp driver to
it and I need that function.
It is not exactly in-tree stuff, but it was
in an ALSA tree for years already, so it is a
close one.
On Thu, 03 May 2007 23:10:02 +0400
Stas Sergeev <[email protected]> wrote:
> Hello.
>
> Peter Zijlstra wrote:
> >> It seems hrtimer_forward was forgotten to
> >> export - other symbols of the hrtimers API
> > Are there actual in-tree users of this symbol? Without we usually leave
> > the symbol unexported, this saves some space.
> Do you mean it was really left intentional?
> Unbeleivable! But why the other parts of a
> hrtimer API are exported nevertheless, and
> only this particular function not?
It was probably an oversight - generally we take the position that all the
formal interface of a subsystem is exported to modules rather than a
piecemeal whichever-bits-kernel.org-happens-to-use-today approach.
Thomas, is hrtimer_forward() considered part of the hrtimer public API?
And are you OK with the patch?
> As for the users - I am porting my pcsp driver to
> it and I need that function.
> It is not exactly in-tree stuff, but it was
> in an ALSA tree for years already, so it is a
> close one.
On Thu, 2007-05-03 at 16:58 -0700, Andrew Morton wrote:
> It was probably an oversight - generally we take the position that all the
> formal interface of a subsystem is exported to modules rather than a
> piecemeal whichever-bits-kernel.org-happens-to-use-today approach.
>
> Thomas, is hrtimer_forward() considered part of the hrtimer public API?
> And are you OK with the patch?
Yes to both.
tglx