2007-05-04 14:08:27

by Satyam Sharma

Subject: [PATCH (trivial)] Fix wrong identifier name in Documentation/kref.txt

Here's another trivial one I've been meaning to send since ... a long
time back.

Cheers,
Satyam

---

There's a typo / wrong identifier name in Documentation/kref.txt. Fix it.

Signed-off-by: Satyam Sharma <[email protected]>

---

diff -ruNp linux-2.6.21.1/Documentation/kref.txt linux-2.6.21.1~patch/Documentation/kref.txt
--- linux-2.6.21.1/Documentation/kref.txt 2007-05-04 19:40:01.000000000 +0530
+++ linux-2.6.21.1~patch/Documentation/kref.txt 2007-05-04 19:41:04.000000000 +0530
@@ -67,7 +67,7 @@ void more_data_handling(void *cb_data)
.
. do stuff with data here
.
- kref_put(data, data_release);
+ kref_put(&data->refcount, data_release);
}

int my_data_handler(void)

2007-05-04 18:49:31

by Corey Minyard

Subject: Re: [PATCH (trivial)] Fix wrong identifier name in Documentation/kref.txt

Yes, please add this. Thanks.

-corey

Satyam Sharma wrote:
> Here's another trivial one I've been meaning to send since ... a long
> time back.
>
> Cheers,
> Satyam
>
> ---
>
> There's a typo / wrong identifier name in Documentation/kref.txt. Fix it.
>
> Signed-off-by: Satyam Sharma <[email protected]>
>
> ---
>
> diff -ruNp linux-2.6.21.1/Documentation/kref.txt
> linux-2.6.21.1~patch/Documentation/kref.txt
> --- linux-2.6.21.1/Documentation/kref.txt 2007-05-04
> 19:40:01.000000000 +0530
> +++ linux-2.6.21.1~patch/Documentation/kref.txt 2007-05-04
> 19:41:04.000000000 +0530
> @@ -67,7 +67,7 @@ void more_data_handling(void *cb_data)
> .
> . do stuff with data here
> .
> - kref_put(data, data_release);
> + kref_put(&data->refcount, data_release);
> }
>
> int my_data_handler(void)

2007-05-10 04:32:18

by Satyam Sharma

Subject: Re: [PATCH (trivial)] Fix wrong identifier name in Documentation/kref.txt

Hi Adrian,

Nobody seems to have picked this up -- I didn't see it in the other
trivial stuff you pushed to Linus earlier today (my mistake, I hadn't
copied you in the original post), and it's not in the latest git either.
If somebody can please pick this up for upstream ...

Thanks,
Satyam


On Fri, 4 May 2007, Corey Minyard wrote:
> Yes, please add this. Thanks.
>
> -corey
>
> Satyam Sharma wrote:
>> Here's another trivial one I've been meaning to send since ... a long time
>> back.
>>
>> Cheers,
>> Satyam
>>
>> ---
>>
>> There's a typo / wrong identifier name in Documentation/kref.txt. Fix it.
>>
>> Signed-off-by: Satyam Sharma <[email protected]>
>>
>> ---
>>
>> diff -ruNp linux-2.6.21.1/Documentation/kref.txt
>> linux-2.6.21.1~patch/Documentation/kref.txt
>> --- linux-2.6.21.1/Documentation/kref.txt 2007-05-04 19:40:01.000000000
>> +0530
>> +++ linux-2.6.21.1~patch/Documentation/kref.txt 2007-05-04
>> 19:41:04.000000000 +0530
>> @@ -67,7 +67,7 @@ void more_data_handling(void *cb_data)
>> .
>> . do stuff with data here
>> .
>> - kref_put(data, data_release);
>> + kref_put(&data->refcount, data_release);
>> }
>>
>> int my_data_handler(void)
>
>