2019-05-23 12:55:39

by Michal Rostecki

Subject: [PATCH bpf-next v2 RESEND 0/2] Move bpf_printk to bpf_helpers.h

This series of patches move the commonly used bpf_printk macro to
bpf_helpers.h which is already included in all BPF programs which
defined that macro on their own.

v1->v2:
- If HBM_DEBUG is not defined in hbm sample, undefine bpf_printk and set
an empty macro for it.

Michal Rostecki (2):
selftests: bpf: Move bpf_printk to bpf_helpers.h
samples: bpf: Do not define bpf_printk macro

samples/bpf/hbm_kern.h | 11 ++---------
samples/bpf/tcp_basertt_kern.c | 7 -------
samples/bpf/tcp_bufs_kern.c | 7 -------
samples/bpf/tcp_clamp_kern.c | 7 -------
samples/bpf/tcp_cong_kern.c | 7 -------
samples/bpf/tcp_iw_kern.c | 7 -------
samples/bpf/tcp_rwnd_kern.c | 7 -------
samples/bpf/tcp_synrto_kern.c | 7 -------
samples/bpf/tcp_tos_reflect_kern.c | 7 -------
samples/bpf/xdp_sample_pkts_kern.c | 7 -------
tools/testing/selftests/bpf/bpf_helpers.h | 8 ++++++++
.../testing/selftests/bpf/progs/sockmap_parse_prog.c | 7 -------
.../selftests/bpf/progs/sockmap_tcp_msg_prog.c | 7 -------
.../selftests/bpf/progs/sockmap_verdict_prog.c | 7 -------
.../testing/selftests/bpf/progs/test_lwt_seg6local.c | 7 -------
tools/testing/selftests/bpf/progs/test_xdp_noinline.c | 7 -------
tools/testing/selftests/bpf/test_sockmap_kern.h | 7 -------
17 files changed, 10 insertions(+), 114 deletions(-)

--
2.21.0

2019-05-23 17:15:26

by Yonghong Song

Subject: Re: [PATCH bpf-next v2 RESEND 0/2] Move bpf_printk to bpf_helpers.h

On 5/23/19 5:53 AM, Michal Rostecki wrote:
> This series of patches move the commonly used bpf_printk macro to
> bpf_helpers.h which is already included in all BPF programs which
> defined that macro on their own.
>
> v1->v2:
> - If HBM_DEBUG is not defined in hbm sample, undefine bpf_printk and set
> an empty macro for it.
>
> Michal Rostecki (2):
> selftests: bpf: Move bpf_printk to bpf_helpers.h
> samples: bpf: Do not define bpf_printk macro
>
> samples/bpf/hbm_kern.h | 11 ++---------
> samples/bpf/tcp_basertt_kern.c | 7 -------
> samples/bpf/tcp_bufs_kern.c | 7 -------
> samples/bpf/tcp_clamp_kern.c | 7 -------
> samples/bpf/tcp_cong_kern.c | 7 -------
> samples/bpf/tcp_iw_kern.c | 7 -------
> samples/bpf/tcp_rwnd_kern.c | 7 -------
> samples/bpf/tcp_synrto_kern.c | 7 -------
> samples/bpf/tcp_tos_reflect_kern.c | 7 -------
> samples/bpf/xdp_sample_pkts_kern.c | 7 -------
> tools/testing/selftests/bpf/bpf_helpers.h | 8 ++++++++
> .../testing/selftests/bpf/progs/sockmap_parse_prog.c | 7 -------
> .../selftests/bpf/progs/sockmap_tcp_msg_prog.c | 7 -------
> .../selftests/bpf/progs/sockmap_verdict_prog.c | 7 -------
> .../testing/selftests/bpf/progs/test_lwt_seg6local.c | 7 -------
> tools/testing/selftests/bpf/progs/test_xdp_noinline.c | 7 -------
> tools/testing/selftests/bpf/test_sockmap_kern.h | 7 -------
> 17 files changed, 10 insertions(+), 114 deletions(-)

Ack for the whole series.
Acked-by: Yonghong Song <[email protected]>

2019-05-24 20:51:20

by Alexei Starovoitov

Subject: Re: [PATCH bpf-next v2 RESEND 0/2] Move bpf_printk to bpf_helpers.h

On Thu, May 23, 2019 at 9:52 AM Yonghong Song <[email protected]> wrote:
>
>
>
> On 5/23/19 5:53 AM, Michal Rostecki wrote:
> > This series of patches move the commonly used bpf_printk macro to
> > bpf_helpers.h which is already included in all BPF programs which
> > defined that macro on their own.
> >
> > v1->v2:
> > - If HBM_DEBUG is not defined in hbm sample, undefine bpf_printk and set
> > an empty macro for it.
> >
> > Michal Rostecki (2):
> > selftests: bpf: Move bpf_printk to bpf_helpers.h
> > samples: bpf: Do not define bpf_printk macro
> >
> > samples/bpf/hbm_kern.h | 11 ++---------
> > samples/bpf/tcp_basertt_kern.c | 7 -------
> > samples/bpf/tcp_bufs_kern.c | 7 -------
> > samples/bpf/tcp_clamp_kern.c | 7 -------
> > samples/bpf/tcp_cong_kern.c | 7 -------
> > samples/bpf/tcp_iw_kern.c | 7 -------
> > samples/bpf/tcp_rwnd_kern.c | 7 -------
> > samples/bpf/tcp_synrto_kern.c | 7 -------
> > samples/bpf/tcp_tos_reflect_kern.c | 7 -------
> > samples/bpf/xdp_sample_pkts_kern.c | 7 -------
> > tools/testing/selftests/bpf/bpf_helpers.h | 8 ++++++++
> > .../testing/selftests/bpf/progs/sockmap_parse_prog.c | 7 -------
> > .../selftests/bpf/progs/sockmap_tcp_msg_prog.c | 7 -------
> > .../selftests/bpf/progs/sockmap_verdict_prog.c | 7 -------
> > .../testing/selftests/bpf/progs/test_lwt_seg6local.c | 7 -------
> > tools/testing/selftests/bpf/progs/test_xdp_noinline.c | 7 -------
> > tools/testing/selftests/bpf/test_sockmap_kern.h | 7 -------
> > 17 files changed, 10 insertions(+), 114 deletions(-)
>
> Ack for the whole series.
> Acked-by: Yonghong Song <[email protected]>

Applied. Thanks