2007-05-14 09:12:33

by Mike Rapoport

[permalink] [raw]
Subject: pxamci.c fails to compile

The PXA MMC controller does not compile for PXA27x after MMC
reorganization, because it uses protocol defines to implement HW erratum
workaround (lines 232 - 247 of drivers/mmc/host/pxamci.c ).
The following patch fixes it


--
Sincerely yours,
Mike.



Attachments:
mmc_fix.patch (343.00 B)

2007-05-14 09:14:59

by Russell King

[permalink] [raw]
Subject: Re: pxamci.c fails to compile

On Mon, May 14, 2007 at 11:22:04AM +0300, Mike Rapoport wrote:
> The PXA MMC controller does not compile for PXA27x after MMC
> reorganization, because it uses protocol defines to implement HW erratum
> workaround (lines 232 - 247 of drivers/mmc/host/pxamci.c ).
> The following patch fixes it

It's been discussed over the last few days, and the conclusion that has
been reached is that the work-around is in fact itself buggy. The real
fix should be merged soon.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:

2007-05-14 09:58:33

by Pierre Ossman

[permalink] [raw]
Subject: Re: pxamci.c fails to compile

Russell King wrote:
> On Mon, May 14, 2007 at 11:22:04AM +0300, Mike Rapoport wrote:
>> The PXA MMC controller does not compile for PXA27x after MMC
>> reorganization, because it uses protocol defines to implement HW erratum
>> workaround (lines 232 - 247 of drivers/mmc/host/pxamci.c ).
>> The following patch fixes it
>
> It's been discussed over the last few days, and the conclusion that has
> been reached is that the work-around is in fact itself buggy. The real
> fix should be merged soon.
>

Indeed. I have the fix ready to go. I was hoping I could get some fix for at91
aswell, but that doesn't seem to be happening so I'll push in a bit.

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org