2007-05-29 14:10:36

by Michal Piotrowski

[permalink] [raw]
Subject: Re: [PATCH] reduce AER init error information

Hi all,

Zhang, Yanmin napisał(a):
> PCI-Express AER support in kernel requires BIOS to provide _OSC support
> to allow the AER Root port service driver to request for native control
> of AER. If a root port supports AER capablity, but BIOS doesn't provide
> _OSC for it, aerdriver will print many debug information to system console.
> Below is a log example.
>
> *******************Error information example************
> Evaluate _OSC Set fails. Status = 0x0005
> Evaluate _OSC Set fails. Status = 0x0005
> aer_init: AER service init fails - Run ACPI _OSC fails
> aer: probe of 0000:00:02.0:pcie01 failed with error 2
> Evaluate _OSC Set fails. Status = 0x0005
> Evaluate _OSC Set fails. Status = 0x0005
> aer_init: AER service init fails - Run ACPI _OSC fails
> aer: probe of 0000:00:04.0:pcie01 failed with error 2
> Evaluate _OSC Set fails. Status = 0x0005
> Evaluate _OSC Set fails. Status = 0x0005
> aer_init: AER service init fails - Run ACPI _OSC fails
> aer: probe of 0000:00:06.0:pcie01 failed with error 2
> ******************End of Error information example******
>
>
> As _OSC is an optional capability of BIOS, such error information looks
> like overly-verbosed. The patch against kernel 2.6.21 changes it to just
> print one line report messages if aerdriver fails to attach the root port
> service device.
>
> Below is an example of new output.
> AER service couldn't init device 0000:00:02.0:pcie01 - no _OSC support
>
>
> Signed-off-by: Zhang Yanmin <[email protected]>
>
> ---
>
[..]

This patch fixes a 2.6.21 regression. Please add this to the -stable and mainline queue.

Regards,
Michal

--
"Najbardziej brakowało mi twojego milczenia."
-- Andrzej Sapkowski "Coś więcej"


2007-05-29 16:49:17

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] reduce AER init error information

On Tue, May 29, 2007 at 04:10:14PM +0200, Michal Piotrowski wrote:
> Hi all,
>
> Zhang, Yanmin napisa??(a):
> > PCI-Express AER support in kernel requires BIOS to provide _OSC support
> > to allow the AER Root port service driver to request for native control
> > of AER. If a root port supports AER capablity, but BIOS doesn't provide
> > _OSC for it, aerdriver will print many debug information to system console.
> > Below is a log example.
> >
> > *******************Error information example************
> > Evaluate _OSC Set fails. Status = 0x0005
> > Evaluate _OSC Set fails. Status = 0x0005
> > aer_init: AER service init fails - Run ACPI _OSC fails
> > aer: probe of 0000:00:02.0:pcie01 failed with error 2
> > Evaluate _OSC Set fails. Status = 0x0005
> > Evaluate _OSC Set fails. Status = 0x0005
> > aer_init: AER service init fails - Run ACPI _OSC fails
> > aer: probe of 0000:00:04.0:pcie01 failed with error 2
> > Evaluate _OSC Set fails. Status = 0x0005
> > Evaluate _OSC Set fails. Status = 0x0005
> > aer_init: AER service init fails - Run ACPI _OSC fails
> > aer: probe of 0000:00:06.0:pcie01 failed with error 2
> > ******************End of Error information example******
> >
> >
> > As _OSC is an optional capability of BIOS, such error information looks
> > like overly-verbosed. The patch against kernel 2.6.21 changes it to just
> > print one line report messages if aerdriver fails to attach the root port
> > service device.
> >
> > Below is an example of new output.
> > AER service couldn't init device 0000:00:02.0:pcie01 - no _OSC support
> >
> >
> > Signed-off-by: Zhang Yanmin <[email protected]>
> >
> > ---
> >
> [..]
>
> This patch fixes a 2.6.21 regression. Please add this to the -stable and mainline queue.

Care to forward the above patch to the [email protected] address after
it goes into Linus's tree?

thanks,

greg k-h

2007-05-29 21:07:33

by Linus Torvalds

[permalink] [raw]
Subject: Re: [PATCH] reduce AER init error information



On Tue, 29 May 2007, Greg KH wrote:
>
> Care to forward the above patch to the [email protected] address after
> it goes into Linus's tree?

.. talking about going to my tree, where _is_ it? It's not in my mailbox,
at least..

Linus

2007-06-01 17:14:20

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] reduce AER init error information

On Tue, May 29, 2007 at 02:06:52PM -0700, Linus Torvalds wrote:
>
>
> On Tue, 29 May 2007, Greg KH wrote:
> >
> > Care to forward the above patch to the [email protected] address after
> > it goes into Linus's tree?
>
> .. talking about going to my tree, where _is_ it? It's not in my mailbox,
> at least..

I tried to get this to work for the last round of PCI patches that I
sent you yesterday, but it had build problems, which I need to spend
some time fixing up :(

thanks,

greg k-h

2007-06-04 03:50:29

by Yanmin Zhang

[permalink] [raw]
Subject: Re: [PATCH] reduce AER init error information

On Fri, 2007-06-01 at 05:04 -0700, Greg KH wrote:
> On Tue, May 29, 2007 at 02:06:52PM -0700, Linus Torvalds wrote:
> >
> >
> > On Tue, 29 May 2007, Greg KH wrote:
> > >
> > > Care to forward the above patch to the [email protected] address after
> > > it goes into Linus's tree?
> >
> > .. talking about going to my tree, where _is_ it? It's not in my mailbox,
> > at least..
>
> I tried to get this to work for the last round of PCI patches that I
> sent you yesterday, but it had build problems, which I need to spend
> some time fixing up :(
>
I fixed by patch at http://marc.info/?l=linux-kernel&m=117783233918191&w=2.
Later on, someone found if CONFIG_ACPI=n, there is a compilation error. Then,
I sent out a new patch to fix the compilation error, but another guy wants
AER driver support although CONFIG_ACPI=n. He sent out the 3rd patch to fix the
compilation error and enables AER driver when CONFIG_ACPI=n.

So pls. apply 2 patches.

1) http://marc.info/?l=linux-kernel&m=117783233918191&w=2;
2) http://marc.info/?l=linux-mm-commits&m=118046936720790&w=2

When patch 2 is applied to stable kernel 2.6.21.3, there is a fuzz warning.
It doesn't matter.

Sorry for replying so late.

Yanmin