2007-06-11 11:01:27

by Tobias Oed

Subject: [RESENT][TRIVIAL][PATCH] SELinux: Use %lu for inode->i_no when printing avcs

Resending this to a wider audience since the first attempt was mangled
and I haven't heard anything in a week.

Inode numbers are unsigned long and so need to %lu as format string of
printf. I have no idea why the __attribute__((format,..)) of
audit_log_format
doesn't give us a warning.
Compile tested only.

Signed-off-by: Tobias Oed <[email protected]>

--- linux-2.6.21.3/security/selinux/avc.c.orig 2007-06-11
12:19:28.000000000 +0200
+++ linux-2.6.21.3/security/selinux/avc.c 2007-06-04
21:19:22.000000000 +0200
@@ -584,7 +584,7 @@ void avc_audit(u32 ssid, u32 tsid,
}
}
if (inode)
- audit_log_format(ab, " dev=%s ino=%ld",
+ audit_log_format(ab, " dev=%s ino=%lu",
inode->i_sb->s_id,
inode->i_ino);
break;

2007-06-11 13:07:01

by James Morris

Subject: Re: [RESENT][TRIVIAL][PATCH] SELinux: Use %lu for inode->i_no when printing avcs

On Mon, 11 Jun 2007, Tobias Oed wrote:

> Resending this to a wider audience since the first attempt was mangled
> and I haven't heard anything in a week.
>
> Inode numbers are unsigned long and so need to %lu as format string of
> printf. I have no idea why the __attribute__((format,..)) of
> audit_log_format
> doesn't give us a warning.
> Compile tested only.
>
> Signed-off-by: Tobias Oed <[email protected]>

Thanks, tested & applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm




--
James Morris
<[email protected]>