Fix the following coccicheck warning:
./drivers/memory/tegra/tegra20-emc.c:915:0-23: WARNING:
tegra_emc_debug_max_rate_fops should be defined with
DEFINE_DEBUGFS_ATTRIBUTE
./drivers/memory/tegra/tegra20-emc.c:885:0-23: WARNING:
tegra_emc_debug_min_rate_fops should be defined with
DEFINE_DEBUGFS_ATTRIBUTE
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/memory/tegra/tegra20-emc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
index 77c5cd5..f4d3470 100644
--- a/drivers/memory/tegra/tegra20-emc.c
+++ b/drivers/memory/tegra/tegra20-emc.c
@@ -882,7 +882,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_min_rate_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops,
tegra_emc_debug_min_rate_get,
tegra_emc_debug_min_rate_set, "%llu\n");
@@ -912,7 +912,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_max_rate_fops,
+DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops,
tegra_emc_debug_max_rate_get,
tegra_emc_debug_max_rate_set, "%llu\n");
--
1.8.3.1
On 19/10/2021 10:31, Yang Li wrote:
> Fix the following coccicheck warning:
> ./drivers/memory/tegra/tegra20-emc.c:915:0-23: WARNING:
> tegra_emc_debug_max_rate_fops should be defined with
> DEFINE_DEBUGFS_ATTRIBUTE
> ./drivers/memory/tegra/tegra20-emc.c:885:0-23: WARNING:
> tegra_emc_debug_min_rate_fops should be defined with
> DEFINE_DEBUGFS_ATTRIBUTE
>
> Reported-by: Abaci Robot <[email protected]>
Where is the report? If it is not public, it's not reported-by.
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/memory/tegra/tegra20-emc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
NAK, it's the 6th patch for DEFINE_SIMPLE_ATTRIBUTE in Tegra memory
controller drivers. Several folks from alibaba and zte.com.cn keep
sending patches replacing only one line each time. Leaving all others
not touched.
It's my mistake I actually accepted this, so this ends now.
This is not a warning, this is not a bug. It is rather a coding
convention, so sending such one-by-one is unnecessary churn. Pointless
patches...
Replace all of such patterns or don't send it.
Best regards,
Krzysztof