Should we put these patches in 2.6.21-stable?
Gentoo developers did a full backport:
http://marc.info/?l=linux-ide&m=118047865916766&w=2
<added Daniel to CC:>
On Thu, Jun 14, 2007 at 12:01:14PM -0400, Chuck Ebbert wrote:
> Should we put these patches in 2.6.21-stable?
>
> Gentoo developers did a full backport:
>
> http://marc.info/?l=linux-ide&m=118047865916766&w=2
I think it looks way too big.
If there are smaller patches, it might be a bit more reasonable.
Are there reported bugs that this patchset fixes?
thanks,
greg k-h
On Thu, 14 Jun 2007, Greg KH wrote:
> Are there reported bugs that this patchset fixes?
Yes, at least one I opened and which got a CODE_FIX when Tejun prepared the
first version of the patch.
http://bugzilla.kernel.org/show_bug.cgi?id=7838
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
Greg KH wrote:
> I think it looks way too big.
Agreed (otherwise I would have submitted the patches already).
> If there are smaller patches, it might be a bit more reasonable.
It may be possible to get rid of the couple of unrelated ones (sd
printing, SCSI constants). These were required for the real patches to
be able to build, but it would probably be easy to modify the real
patches to build against kernels without those otherwise unrelated patches.
> Are there reported bugs that this patchset fixes?
Yes, but they are not regressions - libata has never done this right
until now.
Here are a few:
https://bugs.gentoo.org/show_bug.cgi?id=174373
http://bugzilla.kernel.org/show_bug.cgi?id=7674
http://bugzilla.kernel.org/show_bug.cgi?id=7838
https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.17/+bug/67810
Daniel
On Thu, Jun 14, 2007 at 01:48:46PM -0400, Daniel Drake wrote:
> Greg KH wrote:
> > I think it looks way too big.
>
> Agreed (otherwise I would have submitted the patches already).
>
> > If there are smaller patches, it might be a bit more reasonable.
>
> It may be possible to get rid of the couple of unrelated ones (sd printing,
> SCSI constants). These were required for the real patches to be able to
> build, but it would probably be easy to modify the real patches to build
> against kernels without those otherwise unrelated patches.
>
> > Are there reported bugs that this patchset fixes?
>
> Yes, but they are not regressions - libata has never done this right until
> now.
>
> Here are a few:
> https://bugs.gentoo.org/show_bug.cgi?id=174373
> http://bugzilla.kernel.org/show_bug.cgi?id=7674
> http://bugzilla.kernel.org/show_bug.cgi?id=7838
> https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.17/+bug/67810
Ok, if people want to post some smaller patches to the stable team,
we'll be glad to consider them.
thanks,
greg k-h