2004-10-04 18:53:37

by Sy, Dely L

[permalink] [raw]
Subject: RE: Fw: 2.6.8-rc2-mm4 does not link (PPC)

On Friday, October 01, 2004 3:25 PM, Greg KH wrote:
> > It looks like a trivial error: a structure used in PCI architecture
> > independent code (quirks.c) gets defined (only) in i386 architecture
> > (raw_pci_ops). I'm not an expert and cannot help to define this
under
> > ppc arch:
>
> > drivers/built-in.o(.text+0x350a): In function
`quirk_pcie_aspm_read':
> > : undefined reference to `raw_pci_ops'
> > drivers/built-in.o(.text+0x351e): In function
`quirk_pcie_aspm_read':
> > : undefined reference to `raw_pci_ops'
> > drivers/built-in.o(.text+0x3566): In function
`quirk_pcie_aspm_write':
> > : undefined reference to `raw_pci_ops'
> > drivers/built-in.o(.text+0x35a6): In function
`quirk_pcie_aspm_write':
> > : undefined reference to `raw_pci_ops'
> > make: *** [.tmp_vmlinux1] Error 1
> >
> > I sent a typo for rc2-mm2. Just to report that it never booted after
> > the typo was corrected. hard freeze.

> Dely, we need to move this quirk to i386 specific code. Will we also
> have to do this for the x86-64 platform too?

> Care to send a patch to fix this?

We need to have the quirk for x86-64 platform too. I'll look into moving
the quirk to architecture specific code and send out a patch.

Thanks,
Dely