2022-11-24 04:55:24

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the slab tree

---

Hi all,

After merging the slab tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

mm/slab_common.c: In function 'kmem_dump_obj':
mm/slab_common.c:603:49: error: 'struct kmem_cache' has no member named 'usersize'
603 | if (kp.kp_slab_cache && kp.kp_slab_cache->usersize)
| ^~
In file included from include/asm-generic/bug.h:22,
from arch/powerpc/include/asm/bug.h:159,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/preempt.h:5,
from ./arch/powerpc/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:56,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/slab.h:15,
from mm/slab_common.c:7:
mm/slab_common.c:604:53: error: 'struct kmem_cache' has no member named 'usersize'
604 | pr_cont(" size %u", kp.kp_slab_cache->usersize);
| ^~
include/linux/printk.h:429:33: note: in definition of macro 'printk_index_wrap'
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:542:9: note: in expansion of macro 'printk'
542 | printk(KERN_CONT fmt, ##__VA_ARGS__)
| ^~~~~~
mm/slab_common.c:604:17: note: in expansion of macro 'pr_cont'
604 | pr_cont(" size %u", kp.kp_slab_cache->usersize);
| ^~~~~~~

Caused by commit

3cdb7b6ad16a ("mm, slab: ignore hardened usercopy parameters when disabled")

I have used the slab tree from next-20221123 for today.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-11-24 09:14:14

by Vlastimil Babka

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the slab tree

---

On 11/24/22 05:39, Stephen Rothwell wrote:
> Hi all,
>
> After merging the slab tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:

Oops, thanks, looks like I had !CONFIG_PRINTK when testing that... Will be
fixed in the next slab-next.

> mm/slab_common.c: In function 'kmem_dump_obj':
> mm/slab_common.c:603:49: error: 'struct kmem_cache' has no member named 'usersize'
> 603 | if (kp.kp_slab_cache && kp.kp_slab_cache->usersize)
> | ^~
> In file included from include/asm-generic/bug.h:22,
> from arch/powerpc/include/asm/bug.h:159,
> from include/linux/bug.h:5,
> from include/linux/thread_info.h:13,
> from include/asm-generic/preempt.h:5,
> from ./arch/powerpc/include/generated/asm/preempt.h:1,
> from include/linux/preempt.h:78,
> from include/linux/spinlock.h:56,
> from include/linux/mmzone.h:8,
> from include/linux/gfp.h:7,
> from include/linux/slab.h:15,
> from mm/slab_common.c:7:
> mm/slab_common.c:604:53: error: 'struct kmem_cache' has no member named 'usersize'
> 604 | pr_cont(" size %u", kp.kp_slab_cache->usersize);
> | ^~
> include/linux/printk.h:429:33: note: in definition of macro 'printk_index_wrap'
> 429 | _p_func(_fmt, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> include/linux/printk.h:542:9: note: in expansion of macro 'printk'
> 542 | printk(KERN_CONT fmt, ##__VA_ARGS__)
> | ^~~~~~
> mm/slab_common.c:604:17: note: in expansion of macro 'pr_cont'
> 604 | pr_cont(" size %u", kp.kp_slab_cache->usersize);
> | ^~~~~~~
>
> Caused by commit
>
> 3cdb7b6ad16a ("mm, slab: ignore hardened usercopy parameters when disabled")
>
> I have used the slab tree from next-20221123 for today.
>