2007-08-01 15:17:58

by Michal Piotrowski

Subject: [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c

Hi,

Coding style fix

Regards,
Michal

--
LOG
http://www.stardust.webpages.pl/log/

Signed-off-by: Michal Piotrowski <[email protected]>

--- linux-mm-clean/drivers/scsi/mvme147.c 2007-07-09 01:32:17.000000000 +0200
+++ linux-mm/drivers/scsi/mvme147.c 2007-08-01 17:14:39.000000000 +0200
@@ -13,7 +13,7 @@
#include "wd33c93.h"
#include "mvme147.h"

-#include<linux/stat.h>
+#include <linux/stat.h>

#define HDATA(ptr) ((struct WD33C93_hostdata *)((ptr)->hostdata))

2007-08-01 15:20:57

by Matthew Wilcox

Subject: Re: [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c

On Wed, Aug 01, 2007 at 05:17:15PM +0200, Michal Piotrowski wrote:
> -#include<linux/stat.h>
> +#include <linux/stat.h>

Why does this driver need stat.h at all?

--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."

2007-08-01 15:26:50

by Michal Piotrowski

Subject: Re: [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c

Michal Piotrowski pisze:
> Hi,
>
> Coding style fix
>

Christoph Hellwig:
"There is no reason at all for a scsi driver to include stat.h"

Regards,
Michal

--
LOG
http://www.stardust.webpages.pl/log/

Signed-off-by: Michal Piotrowski <[email protected]>

--- linux-mm-clean/drivers/scsi/mvme147.c 2007-07-09 01:32:17.000000000 +0200
+++ linux-mm/drivers/scsi/mvme147.c 2007-08-01 17:24:22.000000000 +0200
@@ -13,8 +13,6 @@
#include "wd33c93.h"
#include "mvme147.h"

-#include<linux/stat.h>
-
#define HDATA(ptr) ((struct WD33C93_hostdata *)((ptr)->hostdata))

static struct Scsi_Host *mvme147_host = NULL;