2007-08-01 15:13:55

by Michal Piotrowski

Subject: [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c

Hi,

Coding style fix

Regards,
Michal

--
LOG
http://www.stardust.webpages.pl/log/

Signed-off-by: Michal Piotrowski <[email protected]>

--- linux-mm-clean/drivers/scsi/aha1542.c 2007-07-09 01:32:17.000000000 +0200
+++ linux-mm/drivers/scsi/aha1542.c 2007-08-01 17:09:40.000000000 +0200
@@ -77,7 +77,7 @@ static void BAD_SG_DMA(Scsi_Cmnd * SCpnt
panic("Buffer at physical address > 16Mb used for aha1542");
}

-#include<linux/stat.h>
+#include <linux/stat.h>

#ifdef DEBUG
#define DEB(x) x

2007-08-01 15:18:44

by Christoph Hellwig

Subject: Re: [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c

On Wed, Aug 01, 2007 at 05:13:14PM +0200, Michal Piotrowski wrote:
> Hi,
>
> Coding style fix
>
> Regards,
> Michal
>

I think that include should just go. There is no reason at all for
a scsi driver to include stat.h

2007-08-01 15:23:22

by Michal Piotrowski

Subject: Re: [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c

Christoph Hellwig pisze:
> On Wed, Aug 01, 2007 at 05:13:14PM +0200, Michal Piotrowski wrote:
>> Hi,
>>
>> Coding style fix
>>
>> Regards,
>> Michal
>>
>
> I think that include should just go. There is no reason at all for
> a scsi driver to include stat.h
>
>

As you wish

Regards,
Michal

--
LOG
http://www.stardust.webpages.pl/log/

Signed-off-by: Michal Piotrowski <[email protected]>

--- linux-mm-clean/drivers/scsi/aha1542.c 2007-07-09 01:32:17.000000000 +0200
+++ linux-mm/drivers/scsi/aha1542.c 2007-08-01 17:18:57.000000000 +0200
@@ -77,8 +77,6 @@ static void BAD_SG_DMA(Scsi_Cmnd * SCpnt
panic("Buffer at physical address > 16Mb used for aha1542");
}

-#include<linux/stat.h>
-
#ifdef DEBUG
#define DEB(x) x
#else