2007-08-02 09:27:19

by Peter Williams

[permalink] [raw]
Subject: [PATCH] Tidy up left over smpnice code after changes introduced with CFS

1. The only place that RTPRIO_TO_LOAD_WEIGHT() is used is in the call to
move_tasks() in the function active_load_balance() and its purpose here
is just to make sure that the load to be moved is big enough to ensure
that exactly one task is moved (if there's one available). This can be
accomplished by using ULONG_MAX instead and this allows
RTPRIO_TO_LOAD_WEIGHT() to be deleted.

2. This, in turn, allows PRIO_TO_LOAD_WEIGHT() to be deleted.

3. This allows load_weight() to be deleted which allows
TIME_SLICE_NICE_ZERO to be deleted along with the comment above it.

Signed-off-by: Peter Williams <[email protected]>

--
Peter Williams [email protected]

"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce


Attachments:
tidy-up-smpnice-code-after-cfs-changes.patch (1.10 kB)

2007-08-02 10:29:34

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] Tidy up left over smpnice code after changes introduced with CFS


* Peter Williams <[email protected]> wrote:

> 1. The only place that RTPRIO_TO_LOAD_WEIGHT() is used is in the call
> to move_tasks() in the function active_load_balance() and its purpose
> here is just to make sure that the load to be moved is big enough to
> ensure that exactly one task is moved (if there's one available).
> This can be accomplished by using ULONG_MAX instead and this allows
> RTPRIO_TO_LOAD_WEIGHT() to be deleted.
>
> 2. This, in turn, allows PRIO_TO_LOAD_WEIGHT() to be deleted.
>
> 3. This allows load_weight() to be deleted which allows
> TIME_SLICE_NICE_ZERO to be deleted along with the comment above it.

thanks, i've added this to my tree.

Ingo