2007-08-06 20:41:53

by Gabriel C

Subject: block/cfq-iosched.c - control reaches end of non-void function warning

Hi Jens,

I just noticed this warning in one of my build logs :

...

block/cfq-iosched.c: In function 'cfq_async_queue_prio':
block/cfq-iosched.c:1430: warning: control reaches end of non-void function

...

Guessing return 0; is missing there.


Regards,

Gabriel

2007-08-07 07:17:44

by Jens Axboe

Subject: Re: block/cfq-iosched.c - control reaches end of non-void function warning

On Mon, Aug 06 2007, Gabriel C wrote:
> Hi Jens,
>
> I just noticed this warning in one of my build logs :
>
> ...
>
> block/cfq-iosched.c: In function 'cfq_async_queue_prio':
> block/cfq-iosched.c:1430: warning: control reaches end of non-void function
>
> ...
>
> Guessing return 0; is missing there.

The default: case ends up in a BUG(), which does not return.

--
Jens Axboe