2007-08-08 06:02:36

by Mariusz Kozlowski

Subject: Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

> > Signed-off-by: Mariusz Kozlowski <[email protected]>
>
> NAK
>
> > - struct n_hdlc *n_hdlc = kmalloc(sizeof(*n_hdlc), GFP_KERNEL);
> > -
> > + struct n_hdlc *n_hdlc;
> > +
> > + n_hdlc = kzalloc(sizeof(*n_hdlc), GFP_KERNEL);
>
> Change looks fine but please keep the original formatting style

Ok. Here it goes (based on 2.6.23-rc1-mm2).

Signed-off-by: Mariusz Kozlowski <[email protected]>

drivers/char/n_hdlc.c | 27451 -> 27413 (-38 bytes)
drivers/char/n_hdlc.o | 107068 -> 107088 (+20 bytes)

drivers/char/n_hdlc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

--- linux-2.6.23-rc1-mm2-a/drivers/char/n_hdlc.c 2007-08-01 08:43:44.000000000 +0200
+++ linux-2.6.23-rc1-mm2-b/drivers/char/n_hdlc.c 2007-08-08 07:50:42.000000000 +0200
@@ -807,13 +807,11 @@ static struct n_hdlc *n_hdlc_alloc(void)
{
struct n_hdlc_buf *buf;
int i;
- struct n_hdlc *n_hdlc = kmalloc(sizeof(*n_hdlc), GFP_KERNEL);
+ struct n_hdlc *n_hdlc = kzalloc(sizeof(*n_hdlc), GFP_KERNEL);

if (!n_hdlc)
return NULL;

- memset(n_hdlc, 0, sizeof(*n_hdlc));
-
n_hdlc_buf_list_init(&n_hdlc->rx_free_buf_list);
n_hdlc_buf_list_init(&n_hdlc->tx_free_buf_list);
n_hdlc_buf_list_init(&n_hdlc->rx_buf_list);

2007-08-08 21:40:57

by Krzysztof Halasa

Subject: Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

Mariusz Kozlowski <[email protected]> writes:

> Signed-off-by: Mariusz Kozlowski <[email protected]>
>
> drivers/char/n_hdlc.c | 27451 -> 27413 (-38 bytes)
> drivers/char/n_hdlc.o | 107068 -> 107088 (+20 bytes)

BTW: drivers/char/n_hdlc is a very different thing than these
in drivers/net/wan/ and I have no connection with it. Not sure
who is responsible, if anyone.
--
Krzysztof Halasa

2007-08-08 21:59:21

by Paul Fulghum

Subject: Re: [PATCH 55] drivers/char/n_hdlc.c: kmalloc + memset conversion to kzalloc

Krzysztof Halasa wrote:
> Mariusz Kozlowski <[email protected]> writes:
>
>> Signed-off-by: Mariusz Kozlowski <[email protected]>
>>
>> drivers/char/n_hdlc.c | 27451 -> 27413 (-38 bytes)
>> drivers/char/n_hdlc.o | 107068 -> 107088 (+20 bytes)
>
> BTW: drivers/char/n_hdlc is a very different thing than these
> in drivers/net/wan/ and I have no connection with it. Not sure
> who is responsible, if anyone.

I am, my email is at the top of n_hdlc.c but there
is no maintainers entry.

--
Paul Fulghum
Microgate Systems, Ltd