Add a generic lg.h file to call the architecture specific one.
Signed-off-by: Steven Rostedt <[email protected]>
---
drivers/lguest/lg.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/lguest/lg.h b/drivers/lguest/lg.h
new file mode 100644
index 0000000..4c4356e
--- /dev/null
+++ b/drivers/lguest/lg.h
@@ -0,0 +1,3 @@
+#ifdef CONFIG_X86_32
+#include "i386/lg.h"
+#endif
--
1.4.4.4
--
On 8/8/07, Steven Rostedt <[email protected]> wrote:
> Add a generic lg.h file to call the architecture specific one.
>
> diff --git a/drivers/lguest/lg.h b/drivers/lguest/lg.h
> new file mode 100644
> index 0000000..4c4356e
> --- /dev/null
> +++ b/drivers/lguest/lg.h
> @@ -0,0 +1,3 @@
> +#ifdef CONFIG_X86_32
> +#include "i386/lg.h"
> +#endif
Wouldn't it be cleaner to do something like the asm/ includes?
I understand that lguest now lives in drivers/ and so we don't put
headers directly in asm-i386 , but we could come up with a similar
thing here.
--
Glauber de Oliveira Costa.
"Free as in Freedom"
http://glommer.net
"The less confident you are, the more serious you have to act."
On Wed, 08 Aug 2007 20:32:13 -0400 Steven Rostedt <[email protected]>
wrote:
>
> Add a generic lg.h file to call the architecture specific one.
Please combine this with the previous patch so that the tree will build
at each step.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
--
On Thu, 9 Aug 2007, Stephen Rothwell wrote:
> On Wed, 08 Aug 2007 20:32:13 -0400 Steven Rostedt <[email protected]>
> wrote:
> >
> > Add a generic lg.h file to call the architecture specific one.
>
> Please combine this with the previous patch so that the tree will build
> at each step.
Yeah, I wanted to do that, but git got confused when I did that, and did
what I didn't want. That was, created a new file in the i386 directory,
and diffed the one in this directory.
I'm really want to keep git knowing the history of the file on moving. I
could just simply cat the two files instead. Would that be acceptible?
-- Steve
Glauber de Oliveira Costa wrote:
> On 8/8/07, Steven Rostedt <[email protected]> wrote:
>> Add a generic lg.h file to call the architecture specific one.
>>
>> diff --git a/drivers/lguest/lg.h b/drivers/lguest/lg.h
>> new file mode 100644
>> index 0000000..4c4356e
>> --- /dev/null
>> +++ b/drivers/lguest/lg.h
>> @@ -0,0 +1,3 @@
>> +#ifdef CONFIG_X86_32
>> +#include "i386/lg.h"
>> +#endif
>
> Wouldn't it be cleaner to do something like the asm/ includes?
> I understand that lguest now lives in drivers/ and so we don't put
> headers directly in asm-i386 , but we could come up with a similar
> thing here.
Yeah, that would be much better, and I don't like having something in
a header file including arch specific files like that. I target to get
lguest going on non x86, so I would like to encourage anyone to think
more than x86 when trying to seperate out something :)
IMHO we should avoid any header files with asm specific code in
drivers/lguest - in a way I prefer having arch/<foo>/lguest to
drivers/lguest/<arch>, would be more esthetically compliant with
the include/asm-<arch> approach too, but thats not a big deal.
Cheers,
Jes