2007-08-11 06:31:24

by Divy Le ray

Subject: [PATCH 2/13] cxgb3 - Update rx coalescing length

From: Divy Le Ray <[email protected]>

Set max Rx coalescing length to 12288

Signed-off-by: Divy Le Ray <[email protected]>
---

drivers/net/cxgb3/common.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h
index c46c249..55922ed 100644
--- a/drivers/net/cxgb3/common.h
+++ b/drivers/net/cxgb3/common.h
@@ -104,7 +104,7 @@ enum {
PROTO_SRAM_LINES = 128, /* size of TP sram */
};

-#define MAX_RX_COALESCING_LEN 16224U
+#define MAX_RX_COALESCING_LEN 12288U

enum {
PAUSE_RX = 1 << 0,

2007-08-14 05:42:49

by Jeff Garzik

Subject: Re: [PATCH 2/13] cxgb3 - Update rx coalescing length

Divy Le Ray wrote:
> From: Divy Le Ray <[email protected]>
>
> Set max Rx coalescing length to 12288
>
> Signed-off-by: Divy Le Ray <[email protected]>
> ---
>
> drivers/net/cxgb3/common.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h
> index c46c249..55922ed 100644
> --- a/drivers/net/cxgb3/common.h
> +++ b/drivers/net/cxgb3/common.h
> @@ -104,7 +104,7 @@ enum {
> PROTO_SRAM_LINES = 128, /* size of TP sram */
> };
>
> -#define MAX_RX_COALESCING_LEN 16224U
> +#define MAX_RX_COALESCING_LEN 12288U

neither the patch nor description explains -why-

2007-08-14 23:22:25

by Divy Le ray

Subject: Re: [PATCH 2/13] cxgb3 - Update rx coalescing length

Jeff Garzik wrote:
>
> Divy Le Ray wrote:
> > From: Divy Le Ray <[email protected]>
> >
> > Set max Rx coalescing length to 12288
> >
> > Signed-off-by: Divy Le Ray <[email protected]>
> > ---
> >
> > drivers/net/cxgb3/common.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h
> > index c46c249..55922ed 100644
> > --- a/drivers/net/cxgb3/common.h
> > +++ b/drivers/net/cxgb3/common.h
> > @@ -104,7 +104,7 @@ enum {
> > PROTO_SRAM_LINES = 128, /* size of TP sram */
> > };
> >
> > -#define MAX_RX_COALESCING_LEN 16224U
> > +#define MAX_RX_COALESCING_LEN 12288U
>
> neither the patch nor description explains -why-
>

We're seeing back pressure from PCIe with large bursts, this patch
allows to cut down on the burst size.

Divy