2015-04-07 02:02:35

by Nickolaus Woodruff

[permalink] [raw]
Subject: [PATCH] staging: lustre: Make cfs_sched_rehash static

This patch fixes the following sparse warning:

CHECK drivers/staging/lustre/lustre/libcfs/hash.c
drivers/staging/lustre/lustre/libcfs/hash.c:119:21: warning: symbol
'cfs_sched_rehash' was not declared. Should it be static?

Signed-off-by: Nickolaus Woodruff <[email protected]>
---
drivers/staging/lustre/lustre/libcfs/hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c b/drivers/staging/lustre/lustre/libcfs/hash.c
index a55567e..a4920a2 100644
--- a/drivers/staging/lustre/lustre/libcfs/hash.c
+++ b/drivers/staging/lustre/lustre/libcfs/hash.c
@@ -116,7 +116,7 @@ module_param(warn_on_depth, uint, 0644);
MODULE_PARM_DESC(warn_on_depth, "warning when hash depth is high.");
#endif

-struct cfs_wi_sched *cfs_sched_rehash;
+static struct cfs_wi_sched *cfs_sched_rehash;

static inline void
cfs_hash_nl_lock(union cfs_hash_lock *lock, int exclusive) {}
--
1.9.1


2015-04-07 09:42:41

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH] staging: lustre: Make cfs_sched_rehash static

On Mon, Apr 06, 2015 at 10:02:27PM -0400, Nickolaus Woodruff wrote:
> This patch fixes the following sparse warning:
>
> CHECK drivers/staging/lustre/lustre/libcfs/hash.c
> drivers/staging/lustre/lustre/libcfs/hash.c:119:21: warning: symbol
> 'cfs_sched_rehash' was not declared. Should it be static?

you have not build tested your patch.
WARNING: "cfs_sched_rehash" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!

it has been used in lustre/lustre/libcfs/module.c

regards
sudip

>

2015-04-07 16:02:09

by Oleg Drokin

[permalink] [raw]
Subject: Re: [HPDD-discuss] [PATCH] staging: lustre: Make cfs_sched_rehash static

If you checked the code, you would see that it's used in drivers/staging/lustre/lustre/libcfs/module.c too.

drivers/staging/lustre/lustre/libcfs/module.c:extern struct cfs_wi_sched *cfs_sched_rehash;
drivers/staging/lustre/lustre/libcfs/module.c: rc, &cfs_sched_rehash);
drivers/staging/lustre/lustre/libcfs/module.c: if (cfs_sched_rehash != NULL) {
drivers/staging/lustre/lustre/libcfs/module.c: cfs_wi_sched_destroy(cfs_sched_rehash);
drivers/staging/lustre/lustre/libcfs/module.c: cfs_sched_rehash = NULL;


On Apr 6, 2015, at 10:02 PM, Nickolaus Woodruff wrote:

> This patch fixes the following sparse warning:
>
> CHECK drivers/staging/lustre/lustre/libcfs/hash.c
> drivers/staging/lustre/lustre/libcfs/hash.c:119:21: warning: symbol
> 'cfs_sched_rehash' was not declared. Should it be static?
>
> Signed-off-by: Nickolaus Woodruff <[email protected]>
> ---
> drivers/staging/lustre/lustre/libcfs/hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c b/drivers/staging/lustre/lustre/libcfs/hash.c
> index a55567e..a4920a2 100644
> --- a/drivers/staging/lustre/lustre/libcfs/hash.c
> +++ b/drivers/staging/lustre/lustre/libcfs/hash.c
> @@ -116,7 +116,7 @@ module_param(warn_on_depth, uint, 0644);
> MODULE_PARM_DESC(warn_on_depth, "warning when hash depth is high.");
> #endif
>
> -struct cfs_wi_sched *cfs_sched_rehash;
> +static struct cfs_wi_sched *cfs_sched_rehash;
>
> static inline void
> cfs_hash_nl_lock(union cfs_hash_lock *lock, int exclusive) {}
> --
> 1.9.1
>
> _______________________________________________
> HPDD-discuss mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/hpdd-discuss