2007-09-26 13:17:27

by Pavel Emelyanov

Subject: [PATCH] Remove unused member from nsproxy

The nslock spinlock is not used in the kernel at all.
Remove it.

Signed-off-by: Pavel Emelyanov <[email protected]>

---

diff --git a/include/linux/init_task.h b/include/linux/init_task.h
index a3f2541..cae35b6 100644
--- a/include/linux/init_task.h
+++ b/include/linux/init_task.h
@@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
#define INIT_NSPROXY(nsproxy) { \
.pid_ns = &init_pid_ns, \
.count = ATOMIC_INIT(1), \
- .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
.uts_ns = &init_uts_ns, \
.mnt_ns = NULL, \
INIT_NET_NS(net_ns) \
diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
index 4d564d8..0e66b57 100644
--- a/include/linux/nsproxy.h
+++ b/include/linux/nsproxy.h
@@ -23,7 +23,6 @@ struct pid_namespace;
*/
struct nsproxy {
atomic_t count;
- spinlock_t nslock;
struct uts_namespace *uts_ns;
struct ipc_namespace *ipc_ns;
struct mnt_namespace *mnt_ns;

2007-09-26 13:28:24

by Serge E. Hallyn

Subject: Re: [PATCH] Remove unused member from nsproxy

Quoting Pavel Emelyanov ([email protected]):
> The nslock spinlock is not used in the kernel at all.
> Remove it.
>
> Signed-off-by: Pavel Emelyanov <[email protected]>

Acked-by: Serge Hallyn <[email protected]>

> ---
>
> diff --git a/include/linux/init_task.h b/include/linux/init_task.h
> index a3f2541..cae35b6 100644
> --- a/include/linux/init_task.h
> +++ b/include/linux/init_task.h
> @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
> #define INIT_NSPROXY(nsproxy) { \
> .pid_ns = &init_pid_ns, \
> .count = ATOMIC_INIT(1), \
> - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
> .uts_ns = &init_uts_ns, \
> .mnt_ns = NULL, \
> INIT_NET_NS(net_ns) \
> diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
> index 4d564d8..0e66b57 100644
> --- a/include/linux/nsproxy.h
> +++ b/include/linux/nsproxy.h
> @@ -23,7 +23,6 @@ struct pid_namespace;
> */
> struct nsproxy {
> atomic_t count;
> - spinlock_t nslock;
> struct uts_namespace *uts_ns;
> struct ipc_namespace *ipc_ns;
> struct mnt_namespace *mnt_ns;

2007-09-26 13:31:32

by Cédric Le Goater

Subject: Re: [PATCH] Remove unused member from nsproxy

Pavel Emelyanov wrote:
> The nslock spinlock is not used in the kernel at all.

it's also useless now that you have put some RCU rules around it.
right ?

C.

> Remove it.
> Signed-off-by: Pavel Emelyanov <[email protected]>
>
> ---
>
> diff --git a/include/linux/init_task.h b/include/linux/init_task.h
> index a3f2541..cae35b6 100644
> --- a/include/linux/init_task.h
> +++ b/include/linux/init_task.h
> @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
> #define INIT_NSPROXY(nsproxy) { \
> .pid_ns = &init_pid_ns, \
> .count = ATOMIC_INIT(1), \
> - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
> .uts_ns = &init_uts_ns, \
> .mnt_ns = NULL, \
> INIT_NET_NS(net_ns) \
> diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
> index 4d564d8..0e66b57 100644
> --- a/include/linux/nsproxy.h
> +++ b/include/linux/nsproxy.h
> @@ -23,7 +23,6 @@ struct pid_namespace;
> */
> struct nsproxy {
> atomic_t count;
> - spinlock_t nslock;
> struct uts_namespace *uts_ns;
> struct ipc_namespace *ipc_ns;
> struct mnt_namespace *mnt_ns;
> _______________________________________________
> Containers mailing list
> [email protected]
> https://lists.linux-foundation.org/mailman/listinfo/containers
>

2007-09-26 13:40:41

by Pavel Emelyanov

Subject: Re: [PATCH] Remove unused member from nsproxy

Cedric Le Goater wrote:
> Pavel Emelyanov wrote:
>> The nslock spinlock is not used in the kernel at all.
>
> it's also useless now that you have put some RCU rules around it.
> right ?

Exactly!

> C.
>
>> Remove it.
>> Signed-off-by: Pavel Emelyanov <[email protected]>
>>
>> ---
>>
>> diff --git a/include/linux/init_task.h b/include/linux/init_task.h
>> index a3f2541..cae35b6 100644
>> --- a/include/linux/init_task.h
>> +++ b/include/linux/init_task.h
>> @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
>> #define INIT_NSPROXY(nsproxy) { \
>> .pid_ns = &init_pid_ns, \
>> .count = ATOMIC_INIT(1), \
>> - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
>> .uts_ns = &init_uts_ns, \
>> .mnt_ns = NULL, \
>> INIT_NET_NS(net_ns) \
>> diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h
>> index 4d564d8..0e66b57 100644
>> --- a/include/linux/nsproxy.h
>> +++ b/include/linux/nsproxy.h
>> @@ -23,7 +23,6 @@ struct pid_namespace;
>> */
>> struct nsproxy {
>> atomic_t count;
>> - spinlock_t nslock;
>> struct uts_namespace *uts_ns;
>> struct ipc_namespace *ipc_ns;
>> struct mnt_namespace *mnt_ns;
>> _______________________________________________
>> Containers mailing list
>> [email protected]
>> https://lists.linux-foundation.org/mailman/listinfo/containers
>>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>