2021-04-13 15:18:03

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI

On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:
> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
> Kunpeng SoCs. Hence add a dependency on ARCH_HISI, to prevent asking
> the user about this driver when configuring a kernel without Hisilicon
> platform support.

Are you *sure* about this? HiSilicon produce a wide range of SoCs with
very diverse target markets, this driver looks like it's for enterprise
stuff while most things guarded by that config option look like they're
for embedded applications.


Attachments:
(No filename) (555.00 B)
signature.asc (499.00 B)
Download all attachments

2021-04-13 15:25:48

by Jay Fang

[permalink] [raw]
Subject: Re: [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI

On 2021/4/13 20:47, Mark Brown wrote:
> On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:
>> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
>> Kunpeng SoCs. Hence add a dependency on ARCH_HISI, to prevent asking
>> the user about this driver when configuring a kernel without Hisilicon
>> platform support.
>
> Are you *sure* about this? HiSilicon produce a wide range of SoCs with
> very diverse target markets, this driver looks like it's for enterprise
> stuff while most things guarded by that config option look like they're
> for embedded applications.
SPI_HISI_KUNPENG does not depend on ARCH_HISI.


Thanks,
Jay