2007-10-12 04:49:18

by Mike Galbraith

[permalink] [raw]
Subject: 2.6.23.git build error

Greetings,

Freshly pulled 2.6.23.git failed to build:

make[1]: *** No rule to make target `arch/x86/kernel/asm-offsets.c', needed by `arch/x86/kernel/asm-offsets.s'. Stop.
make: *** [prepare0] Error 2
make: *** Waiting for unfinished jobs....

-Mike


2007-10-12 21:29:51

by Sam Ravnborg

[permalink] [raw]
Subject: Re: 2.6.23.git build error

On Fri, Oct 12, 2007 at 06:48:58AM +0200, Mike Galbraith wrote:
> Greetings,
>
> Freshly pulled 2.6.23.git failed to build:
>
> make[1]: *** No rule to make target `arch/x86/kernel/asm-offsets.c', needed by `arch/x86/kernel/asm-offsets.s'. Stop.
> make: *** [prepare0] Error 2
> make: *** Waiting for unfinished jobs....

You are the only reporter of this bug.
I do not see it here and I have the asm-offset.c file.

Have you figured out more about this bug?
For now I assume you did something bad when you updated your kernel tree.
Could you as minimum check the content of the arch/x86/kernel/ directory.

Thanks,
Sam

2007-10-13 03:34:30

by Mike Galbraith

[permalink] [raw]
Subject: Re: 2.6.23.git build error

On Fri, 2007-10-12 at 23:31 +0200, Sam Ravnborg wrote:
> On Fri, Oct 12, 2007 at 06:48:58AM +0200, Mike Galbraith wrote:
> > Greetings,
> >
> > Freshly pulled 2.6.23.git failed to build:
> >
> > make[1]: *** No rule to make target `arch/x86/kernel/asm-offsets.c', needed by `arch/x86/kernel/asm-offsets.s'. Stop.
> > make: *** [prepare0] Error 2
> > make: *** Waiting for unfinished jobs....
>
> You are the only reporter of this bug.
> I do not see it here and I have the asm-offset.c file.

Yeah, I noticed nobody else was griping.

> Have you figured out more about this bug?
> For now I assume you did something bad when you updated your kernel tree.
> Could you as minimum check the content of the arch/x86/kernel/ directory.

I just re-pulled, and the little bugger showed up. Elves and Gremlins
at play I guess.

-Mike

2007-10-13 05:45:36

by Giacomo A. Catenazzi

[permalink] [raw]
Subject: Re: 2.6.23.git build error

Mike Galbraith wrote:
> On Fri, 2007-10-12 at 23:31 +0200, Sam Ravnborg wrote:
>> On Fri, Oct 12, 2007 at 06:48:58AM +0200, Mike Galbraith wrote:
>>> Greetings,
>>>
>>> Freshly pulled 2.6.23.git failed to build:
>>>
>>> make[1]: *** No rule to make target `arch/x86/kernel/asm-offsets.c', needed by `arch/x86/kernel/asm-offsets.s'. Stop.
>>> make: *** [prepare0] Error 2
>>> make: *** Waiting for unfinished jobs....
>> You are the only reporter of this bug.
>> I do not see it here and I have the asm-offset.c file.
>
> Yeah, I noticed nobody else was griping.


I also saw this behaiour, but make mrproper solved the problem.


ciao
cate

2007-10-13 07:15:07

by Sam Ravnborg

[permalink] [raw]
Subject: Re: 2.6.23.git build error

On Sat, Oct 13, 2007 at 07:40:09AM +0200, Giacomo Catenazzi wrote:
> Mike Galbraith wrote:
> > On Fri, 2007-10-12 at 23:31 +0200, Sam Ravnborg wrote:
> >> On Fri, Oct 12, 2007 at 06:48:58AM +0200, Mike Galbraith wrote:
> >>> Greetings,
> >>>
> >>> Freshly pulled 2.6.23.git failed to build:
> >>>
> >>> make[1]: *** No rule to make target `arch/x86/kernel/asm-offsets.c', needed by `arch/x86/kernel/asm-offsets.s'. Stop.
> >>> make: *** [prepare0] Error 2
> >>> make: *** Waiting for unfinished jobs....
> >> You are the only reporter of this bug.
> >> I do not see it here and I have the asm-offset.c file.
> >
> > Yeah, I noticed nobody else was griping.
>
>
> I also saw this behaiour, but make mrproper solved the problem.

Pulled 2.6.23 tree and did a build
Added latest -linus on top of it.
Did a new build (x86_64).


As expected it failed due to wrong asm symlink but nothing
like the error Mike posted.
So I'm a bit puzzeled here.

I anyone can explain how to reproduce it I will chase it
but otherwise it will be left as a "consequence of
the x86 merge".

Sam

2007-10-13 07:35:25

by Mike Galbraith

[permalink] [raw]
Subject: Re: 2.6.23.git build error

On Sat, 2007-10-13 at 09:16 +0200, Sam Ravnborg wrote:

> Pulled 2.6.23 tree and did a build
> Added latest -linus on top of it.
> Did a new build (x86_64).
>
>
> As expected it failed due to wrong asm symlink but nothing
> like the error Mike posted.
> So I'm a bit puzzeled here.
>
> I anyone can explain how to reproduce it I will chase it
> but otherwise it will be left as a "consequence of
> the x86 merge".

What I did was to pull, then diff against my working tree (/me=SCM
weenie;) for review as usual, and then apply that diff to working tree
and make oldconfig as usual. That left me with the same failure this
morning, despite the file being verified present in the git tree. I
then used git-archive --format=tar | (cd work_tree;tar -xvf -). That
spewed chunks when I tried to build it even though diff said the trees
were identical. After make mrproper and restoring my saved .config, all
was peachy.

Methinks dontdiff bit me.

-Mike

2007-10-13 08:17:01

by Sam Ravnborg

[permalink] [raw]
Subject: Re: 2.6.23.git build error

On Sat, Oct 13, 2007 at 09:35:09AM +0200, Mike Galbraith wrote:
> On Sat, 2007-10-13 at 09:16 +0200, Sam Ravnborg wrote:
>
> > Pulled 2.6.23 tree and did a build
> > Added latest -linus on top of it.
> > Did a new build (x86_64).
> >
> >
> > As expected it failed due to wrong asm symlink but nothing
> > like the error Mike posted.
> > So I'm a bit puzzeled here.
> >
> > I anyone can explain how to reproduce it I will chase it
> > but otherwise it will be left as a "consequence of
> > the x86 merge".
>
> What I did was to pull, then diff against my working tree (/me=SCM
> weenie;) for review as usual, and then apply that diff to working tree
> and make oldconfig as usual. That left me with the same failure this
> morning, despite the file being verified present in the git tree. I
> then used git-archive --format=tar | (cd work_tree;tar -xvf -). That
> spewed chunks when I tried to build it even though diff said the trees
> were identical. After make mrproper and restoring my saved .config, all
> was peachy.
>
> Methinks dontdiff bit me.

After a quick look:
[sam@neptun x86.git]$ find -name '*.i'
./include/asm-x86/alternative-asm_64.i
./include/asm-x86/alternative-asm_32.i
./include/asm-x86/frame.i
./include/asm-x86/alternative-asm.i
./include/asm-um/frame.i
./include/asm-um/alternative-asm.i
[sam@neptun x86.git]$ grep '*.i' Documentation/dontdiff
*.i

But I cannot see how this could result in the bug you
reported..
Anyway at least one dontdiff buglet - or we should preferably
drop the .i files in the kernel src.

Sam

2007-10-13 09:44:57

by Thomas Gleixner

[permalink] [raw]
Subject: Re: 2.6.23.git build error

On Sat, 13 Oct 2007, Sam Ravnborg wrote:
> But I cannot see how this could result in the bug you
> reported..
> Anyway at least one dontdiff buglet - or we should preferably
> drop the .i files in the kernel src.

I have a patch from Adrian staged to do this.

tglx